1352978 - nsHTML5AttributeName::nameByBuffer allocates too often

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

I hope we could share the instances, similar to NodeInfos, but I'm not really familiar with the setup.

Comment 1

[Henri Sivonen (:hsivonen)]

This implies that the same non-standard attribute repeats a lot. Is there a specific JS lib whose data-* attributes you see repeating in such a pattern that this would be a benefit? I wonder if we should bake some of those into the static atoms.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is from Speedometer, the bug which bug 1351857 blocks.
Speedometer is a silly benchmark from DOM point of view, but less silly from JS point of view, and I'm trying to get DOM out from the profiles as much as possible so that JS folks can focus on the rest.

Comment 3

[Andrew Overholt [:overholt]]

William, I was going to ask you if you could help with some of these parser performance improvements.

Comment 4

[Henri Sivonen (:hsivonen)]

We need to make nsHtml5HtmlAttributes not hold nsHtml5AttributeName instances in bug 1355479 and then we can start reusing a single nsHtml5AttributeName instance for attributes for which we don't have a pre-interned nsHtml5AttributeName instance in this bug.

Comment 5

[Henri Sivonen (:hsivonen)]

Oops. Wrong bug.

Comment 6

[Andrew Overholt [:overholt]]

William, is this still a P1 given other recent changes to the parser?

Comment 7

[William Chen [:wchen]]

Henri, I think you already fixed this bug by reusing AttributeName in bug 1355479. Can you confirm? (I just wanted to make sure that this bug didn't have a different intent before marking as duplicate) Thanks.

Comment 8

[Henri Sivonen (:hsivonen)]

I believe this was fixed by the patch for bug 1355479. (Not marking as duplicate, because what's reported is technically different even if the fix went into the other patch.)