Closed Bug 1353010 Opened 7 years ago Closed 7 years ago

Remove the DirectorRegistry and DirectorManager from DevTools server

Categories

(DevTools :: General, enhancement, P1)

enhancement

Tracking

(Performance Impact:?)

RESOLVED FIXED
Firefox 55
Performance Impact ?

People

(Reporter: pbro, Assigned: pbro)

References

Details

(Whiteboard: [nosdk])

Attachments

(1 file)

In bug 1350645 we're trying to stop using certain SDK APIs, including sdk/loader/sandbox.

Turns out this API is used in one place in DevTools:
http://searchfox.org/mozilla-central/rev/990055a4902952e038cc350c9ffe1ac426d1c943/devtools/server/actors/director-manager.js#14

We should investigate ways to stop using it.
(In reply to Patrick Brosset <:pbro> from comment #0)
> In bug 1350645 we're trying to stop using certain SDK APIs, including
> sdk/loader/sandbox.
> 
> Turns out this API is used in one place in DevTools:
> http://searchfox.org/mozilla-central/rev/
> 990055a4902952e038cc350c9ffe1ac426d1c943/devtools/server/actors/director-
> manager.js#14
> 
> We should investigate ways to stop using it.

It was designed to allow a SDK-based devtools addon to register something similar to an SDK content script on a remote target, the goal was allowing SDK devtools addons to work on both local and remote target using the same or similar APIs.

These actors are never been exposed through the SDK devtool modules though, and I doubt that any addon depends on it, and so we can definitely plan its removal.
Thank you Luca. Let's remove them instead then.
Summary: Stop using sdk/loader/sandbox in DevTools → Remove the DirectorRegistry and DirectorManager from DevTools server
Comment on attachment 8854772 [details]
Bug 1353010 - Remove the unused director-manager/registry API;

https://reviewboard.mozilla.org/r/126760/#review129476

There is no addons using it directly:
https://dxr.mozilla.org/addons/search?q=DirectorManager&redirect=true
Attachment #8854772 - Flags: review?(poirot.alex) → review+
But I think Honza used that in some addons and documented it via examples?
May be we should remove these examples as well?
Flags: needinfo?(odvarko)
(In reply to Alexandre Poirot [:ochameau] from comment #6)
> But I think Honza used that in some addons and documented it via examples?
> May be we should remove these examples as well?
Director-* actors can be safely removed. There are no examples using it.
Thanks for checking!

Honza
Flags: needinfo?(odvarko)
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/846d5472246f
Remove the unused director-manager/registry API; r=ochameau
Whiteboard: [qf]
https://hg.mozilla.org/mozilla-central/rev/846d5472246f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Assignee: nobody → pbrosset
Flags: qe-verify-
Priority: P2 → P1
Whiteboard: [qf] → [nosdk] [qf]
Product: Firefox → DevTools
Performance Impact: --- → ?
Whiteboard: [nosdk] [qf] → [nosdk]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: