1353015 - Get rid of sdk/system/unload usage in the inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P1)

Description

[Patrick Brosset <:pbro>]

In bug 1350645 we're trying to stop using certain SDK APIs including sdk/system/unload.
This one happens to be used in the inspector: https://dxr.mozilla.org/mozilla-central/source/devtools/client/inspector/webpack.config.js#80

However, it doesn't seem to be used anywhere else than inside this webpack config.
So we should be able to remove this line as well as the corresponding file: 
http://searchfox.org/mozilla-central/source/devtools/client/inspector/webpack/system-unload-sham.js

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1353015 - Remove unused reference to sdk/system/unload in the inspector;

Review commit: https://reviewboard.mozilla.org/r/126014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126014/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8854021 [details]
Bug 1353015 - Remove unused reference to sdk/system/unload in the inspector;

https://reviewboard.mozilla.org/r/126014/#review128578

LGTM, thanks for the cleanup!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3600f94a4c71
Remove unused reference to sdk/system/unload in the inspector; r=jdescottes

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3600f94a4c71