Closed
Bug 1353045
Opened 8 years ago
Closed 8 years ago
Stop using SDK in RDM
Categories
(DevTools :: Responsive Design Mode, enhancement, P1)
DevTools
Responsive Design Mode
Tracking
(Performance Impact:?)
People
(Reporter: pbro, Assigned: jryans)
References
Details
(Whiteboard: [nosdk])
Attachments
(1 file)
In bug 1350645 we're trying to stop using certain SDK APIs such as sdk/window/helpers which happens to be used in RDM in these places:
devtools/client/responsive.html/manager.js
devtools/client/responsive.html/test/browser/browser_menu_item_01.js
We should investigate ways to stop using this API.
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P2
|
||
Updated•8 years ago
|
Whiteboard: [qf]
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•8 years ago
|
||
Might as well remove all SDK references here.
Summary: Stop using sdk/window/helpers in RDM → Stop using SDK in RDM
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•8 years ago
|
||
|
Reporter | |
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8855607 [details]
Bug 1353045 - Remove SDK usage from RDM.
https://reviewboard.mozilla.org/r/127456/#review130196
Attachment #8855607 -
Flags: review?(pbrosset) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/63c0820f3407
Remove SDK usage from RDM. r=pbro
|
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•8 years ago
|
Flags: qe-verify-
Priority: P2 → P1
Whiteboard: [qf] → [nosdk] [qf]
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
||
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•