Closed Bug 1353045 Opened 7 years ago Closed 7 years ago

Stop using SDK in RDM

Categories

(DevTools :: Responsive Design Mode, enhancement, P1)

Product:
DevTools
Component:
Responsive Design Mode
Type:
enhancement

Tracking

(Performance Impact:?)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Project Flags:
Performance Impact ?

People

(Reporter: pbro, Assigned: jryans)

References

Details

(Whiteboard: [nosdk])

Attachments

(1 file)

Bug 1353045 - Remove SDK usage from RDM.
59 bytes, text/x-review-board-request
pbro
: review+
Details 
In bug 1350645 we're trying to stop using certain SDK APIs such as sdk/window/helpers which happens to be used in RDM in these places:

devtools/client/responsive.html/manager.js
devtools/client/responsive.html/test/browser/browser_menu_item_01.js

We should investigate ways to stop using this API.
Whiteboard: [qf]
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Might as well remove all SDK references here.
Summary: Stop using sdk/window/helpers in RDM → Stop using SDK in RDM
Comment on attachment 8855607 [details]
Bug 1353045 - Remove SDK usage from RDM.

https://reviewboard.mozilla.org/r/127456/#review130196
Attachment #8855607 - Flags: review?(pbrosset) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/63c0820f3407
Remove SDK usage from RDM. r=pbro
https://hg.mozilla.org/mozilla-central/rev/63c0820f3407
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
See Also: → 1341199
Flags: qe-verify-
Priority: P2 → P1
Whiteboard: [qf] → [nosdk] [qf]
Product: Firefox → DevTools
Performance Impact: --- → ?
status-firefox55: fixed → ---
Whiteboard: [nosdk] [qf] → [nosdk]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: