Closed Bug 1353046 Opened 4 years ago Closed 4 years ago

Thunderbird Daily l10n repacks failing for Windows - subprocess.CalledProcessError: Command '['upx', '--best', '-o', 'c:/users/cltbld/appdata/local/temp/tmphkdwh1/7zSD.sfx', 'other-licenses/7zstub/thunderbird/7zSD.sfx']' returned non-zero exit status 1

Categories

(Thunderbird :: Build Config, defect)

x86
Windows
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 55.0

People

(Reporter: jorgk-bmo, Assigned: ewong)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1345422 +++

Follow up from bug 1345422: I've moved this into a new bug since bug 1345422 had become too confusing.

http://ftp.mozilla.org/pub/thunderbird/nightly/2017/04/2017-04-03-06-55-45-comm-central-l10n/comm-central-win32-l10n-nightly-en-GB-bm72-build1-build872.txt.gz

upx: other-licenses/7zstub/thunderbird/7zSD.sfx: FileNotFoundException: other-licenses/7zstub/thunderbird/7zSD.sfx
Traceback (most recent call last):
  File "c:\mozilla-build\python27\Lib\runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "c:\mozilla-build\python27\Lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File "c:\builds\moz2_slave\tb-c-cen-w32-l10n-ntly-0000000\build\comm-central\mozilla\python\mozbuild\mozbuild\action\7z_exe_archive.py", line 35, in <module>
    sys.exit(main(sys.argv[1:]))
  File "c:\builds\moz2_slave\tb-c-cen-w32-l10n-ntly-0000000\build\comm-central\mozilla\python\mozbuild\mozbuild\action\7z_exe_archive.py", line 31, in main
    archive_exe(args[0], args[1], args[2], args[3])
  File "c:\builds\moz2_slave\tb-c-cen-w32-l10n-ntly-0000000\build\comm-central\mozilla\python\mozbuild\mozbuild\action\7z_exe_archive.py", line 16, in archive_exe
    subprocess.check_call(['upx', '--best', '-o', mozpath.join(tmpdir, '7zSD.sfx'), sfx_package])
  File "c:\mozilla-build\python27\Lib\subprocess.py", line 542, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['upx', '--best', '-o', 'c:/users/cltbld/appdata/local/temp/tmphkdwh1/7zSD.sfx', 'other-licenses/7zstub/thunderbird/7zSD.sfx']' returned non-zero exit status 1
c:/builds/moz2_slave/tb-c-cen-w32-l10n-ntly-0000000/build/comm-central/mozilla/toolkit/locales/l10n.mk:115: recipe for target 'repackage-zip' failed

Looks like the fix from bug 1345422 wasn't quite right for C-C:
https://hg.mozilla.org/comm-central/rev/20d90b5d3da4b80622a7f180c8b6e1dabac286d4#l2.12

Shouldn't that read:
MOZ_SFX_PACKAGE=mozilla/other-licenses/7zstub/thunderbird/7zSD.sfx
Flags: needinfo?(ewong)
(In reply to Jorg K (GMT+2) from comment #0)
> 
> Shouldn't that read:
> MOZ_SFX_PACKAGE=mozilla/other-licenses/7zstub/thunderbird/7zSD.sfx

No.. because in c-c, we have other-licenses/7zstub/{thunderbird,seamonkey,instantbird}/7zSD.sfx.

Will look into this.
Flags: needinfo?(ewong)
(In reply to Jorg K (GMT+2) from comment #1)
> Also failing on Aurora:
> 
> http://ftp.mozilla.org/pub/thunderbird/nightly/2017/04/2017-04-03-09-21-55-
> comm-aurora-l10n/
> http://ftp.mozilla.org/pub/thunderbird/nightly/2017/04/2017-04-03-09-21-55-
> comm-aurora-l10n/comm-aurora-win32-l10n-nightly-ko-bm74-build1-build3197.txt.
> gz
> 
> upx: ../../../other-licenses/7zstub/firefox/7zSD.sfx: FileNotFoundException:
> ../../../other-licenses/7zstub/firefox/7zSD.sfx
https://hg.mozilla.org/comm-central/rev/20d90b5d3da4b80622a7f180c8b6e1dabac286d4#l2.12

wasn't pushed to c-a
(In reply to Edmund Wong (:ewong) from comment #2)
> No.. because in c-c, we have
> other-licenses/7zstub/{thunderbird,seamonkey,instantbird}/7zSD.sfx.
Exactly, I don't understand where I was looking, sorry, my mistake.

(In reply to Edmund Wong (:ewong) from comment #3)
> > upx: ../../../other-licenses/7zstub/firefox/7zSD.sfx: FileNotFoundException:
> > ../../../other-licenses/7zstub/firefox/7zSD.sfx
> https://hg.mozilla.org/comm-central/rev/20d90b5d3da4b80622a7f180c8b6e1dabac286d4#l2.12
> wasn't pushed to c-a
Exactly, I didn't uplift that since https://hg.mozilla.org/mozilla-central/rev/2e22ffe74d41 wasn't uplifted to M-A either.

Let's make it work on C-C and then uplift. Thanks for looking into it, and sorry about my confusion.
Attached patch proposed patch (obsolete) — Splinter Review
I missed the $(topsrcdir) .
Attachment #8854712 - Flags: review?(jorgk)
Attachment #8854712 - Flags: review?(iann_bugzilla)
Attachment #8854712 - Flags: review?(clokep)
Patch is empty :-(
Attachment #8854712 - Flags: review?(jorgk)
Attachment #8854712 - Flags: review?(iann_bugzilla)
Attachment #8854712 - Flags: review?(clokep)
I guess this is what you wanted to do ;-)
Attachment #8854720 - Flags: review+
https://hg.mozilla.org/comm-central/rev/cb74ea57509304cec329ec5c7811b45aaadf2524

Pushed this so we'll see what today's Daily does ;-) - I'll close the bug later.
Thanks Edmund!
Assignee: nobody → ewong
(In reply to Jorg K (GMT+2) from comment #7)
> Created attachment 8854720 [details] [diff] [review]
> 1353046-topsrcdir.patch
> 
> I guess this is what you wanted to do ;-)

daheck am I always doing this?  like this is the nth time.. :(

I'm sorry jorgk.
Worked !!! \o/

http://ftp.mozilla.org/pub/thunderbird/nightly/2017/04/2017-04-05-03-02-11-comm-central-l10n/

All platforms now have C-C repacks! I'll get the uplift to C-A organised.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
Attachment #8854712 - Attachment is obsolete: true
Attachment #8854720 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.