various invoke lint errors for commitindex modules

RESOLVED FIXED

Status

Conduit
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
docker-compose -f /home/dkl/Dropbox/Mozilla/devel/repos/hg/conduit-scratch/docker/docker-compose.yml run --rm py3-linter yapf --diff --recursive tasks.py
--- tasks.py    (original)
+++ tasks.py    (reformatted)
@@ -294,6 +294,7 @@
         echo=True
     )

+
 @task(name='flake8')
 def staginghgserver_lint_flake8(ctx):
     """Run flake8"""
@@ -351,6 +352,7 @@
         ''.format(project_root=project_root),
         echo=True
     )
+

 @task(name='flake8')
 def lint_tasks_flake8(ctx):

----

docker-compose -f /home/dkl/Dropbox/Mozilla/devel/repos/hg/conduit-tip/docker/docker-compose.yml run --rm py3-linter flake8 commitindex
commitindex/tests/test_bmo_attachments.py:8:1: F401 'requests' imported but unused
commitindex/tests/test_bmo_attachments.py:13:1: F401 'commitindex.reviews.triggers.get_bugzilla_client' imported but unused
commitindex/commitindex/commitindex.py:4:1: F401 'os' imported but unused
commitindex/commitindex/reviews/triggers.py:26:9: F841 local variable 'diff_id' is assigned to but never used

----

docker-compose -f /home/dkl/Dropbox/Mozilla/devel/repos/hg/conduit-tip/docker/docker-compose.yml run --rm py3-linter yapf --diff --recursive commitindex
--- commitindex/tests/test_bmo_attachments.py   (original)
+++ commitindex/tests/test_bmo_attachments.py   (reformatted)
@@ -158,8 +158,7 @@
         return bugzilla

     monkeypatch.setattr(
-        "commitindex.reviews.triggers.get_bugzilla_client",
-        get_bugzilla_stub
+        "commitindex.reviews.triggers.get_bugzilla_client", get_bugzilla_stub
     )

     trigger_review(commits)
--- commitindex/commitindex/reviews/bugzilla.py (original)
+++ commitindex/commitindex/reviews/bugzilla.py (reformatted)
@@ -8,7 +8,6 @@
 import logging
 import requests
 from base64 import b64encode
-

 logger = logging.getLogger(__name__)
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8854064 [details]
commitindex: various invoke lint errors for commitindex modules (bug 1353062)

https://reviewboard.mozilla.org/r/126046/#review128628
Attachment #8854064 - Flags: review?(dwalsh) → review+

Comment 3

a year ago
mozreview-review
Comment on attachment 8854064 [details]
commitindex: various invoke lint errors for commitindex modules (bug 1353062)

https://reviewboard.mozilla.org/r/126046/#review128636

rs=mars
Attachment #8854064 - Flags: review+

Comment 4

a year ago
Pushed by mcote@mozilla.com:
https://hg.mozilla.org/automation/conduit/rev/9b67cecd1510
commitindex: various invoke lint errors for commitindex modules r=davidwalsh
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED

Comment 5

a year ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 9bac387c4f85 -d 970b35b04ac0: rebasing 137:9bac387c4f85 "commitindex: various invoke lint errors for commitindex modules (bug 1353062) r=davidwalsh,mars" (tip)
merging commitindex/commitindex/reviews/bugzilla.py
merging commitindex/commitindex/reviews/triggers.py
warning: conflicts while merging commitindex/commitindex/reviews/triggers.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
You need to log in before you can comment on or make changes to this bug.