Closed Bug 1353065 Opened 7 years ago Closed 7 years ago

Reorder thActionButton menu to make it easier to reach frequently used items.

Categories

(Tree Management :: Treeherder, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: KWierso, Assigned: KWierso)

References

Details

Attachments

(2 files, 1 obsolete file)

I've built up muscle memory at this point where I click the bottom-most item in the menu to "set as bottom of range". With the new test-centric button now at the bottom of the menu, I've clicked it a few times already this morning.
Comment on attachment 8854065 [details] [review]
[treeherder] KWierso:testcentric > mozilla:master

Other option: Move the menu item up a few entries, above "set as top of range"?
Attachment #8854065 - Flags: review?(cdawson)
I think if the menu item has to be opt-in it might as well be deleted.

As such I think the options really are:
1) Remove the menu item entirely
2) Move the menu item to somewhere not at the bottom
3) Wontfix and accept that muscle memory occasionally needs to be retrained

My preference would be to decide where we'd put the link if it weren't "Experimental", and if that's the bottom then do #3, else #2. (I'm presuming at the moment it's at the bottom to keep experimental features separate, but I think moving it now is fine, since it will avoid future churn.)
Blocks: 1351092
Assignee: nobody → wkocher
Comment on attachment 8854065 [details] [review]
[treeherder] KWierso:testcentric > mozilla:master

I'd prefer one of the other options :-)
Attachment #8854065 - Flags: review?(cdawson)
Philor, thoughts? I'm already no longer accidentally hitting the new menu item, so I'm happy leaving things unchanged unless it's still affecting your workflow.
Flags: needinfo?(philringnalda)
Flags: needinfo?(philringnalda)
Our current organization seems to be

Thing used to add jobs
-------------------
Thing used by sheriffs on mozilla-central and release branches to mark bugs
-------------------
Three things used to add jobs
-------------------
Two things used to control what pushes are shown
-------------------
Experimental

macOS HIG says to group similar and put frequently-used at the top, GNOME HIG says to group similar but being more geeky and thus more useful advice given Treeherder's market, also says that both the top and bottom are more noticeable and easier to hit and should be reserved for the most interesting and useful things (it's not just muscle-memory, it's about the fact that there are only two menuitem positions, first and last, that you can hit without having to  aim much or read the text to be sure it's the one you want, so it's a shame to waste them). I'd say that means we should instead have

Add new jobs
BuildAPI
Trigger missing jobs
Trigger all Talos jobs
Mark with Bugherder
Experimental: Show the failing tests in the hidden Android WebGL suite
Set as top of range
Set as bottom of range

which might also, by separating Bugherder and BuildAPI, cut down on the number of times that we've all sat staring at BuildAPI wondering why we opened it after merging to m-c.
Comment on attachment 8858680 [details] [review]
[treeherder] KWierso:menureorg > mozilla:master

Here's philor's suggested menu order. I don't have a problem with it.
Attachment #8858680 - Flags: feedback?(ryanvm)
Attachment #8858680 - Flags: feedback?(cbook)
Attachment #8858680 - Flags: feedback?(aryx.bugmail)
Attachment #8858681 - Flags: feedback?(ryanvm)
Attachment #8858681 - Flags: feedback?(cbook)
Attachment #8858681 - Flags: feedback?(aryx.bugmail)
Attachment #8858680 - Flags: feedback?(ryanvm)
Attachment #8858680 - Flags: feedback?(cbook)
Attachment #8858680 - Flags: feedback?(aryx.bugmail)
Comment on attachment 8858681 [details]
actionbuttonmenu.png

Fine with me.
Attachment #8858681 - Flags: feedback?(ryanvm) → feedback+
Summary: Make the test-centric menu item be opt-in. → Reorder thActionButton menu to make it easier to reach frequently used items.
Comment on attachment 8858681 [details]
actionbuttonmenu.png

fine with me
Attachment #8858681 - Flags: feedback?(cbook) → feedback+
Comment on attachment 8858680 [details] [review]
[treeherder] KWierso:menureorg > mozilla:master

r=me presuming you've tested locally :-)
Attachment #8858680 - Flags: review?(emorley) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: