Closed
Bug 1353065
Opened 7 years ago
Closed 7 years ago
Reorder thActionButton menu to make it easier to reach frequently used items.
Categories
(Tree Management :: Treeherder, enhancement)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: KWierso, Assigned: KWierso)
References
Details
Attachments
(2 files, 1 obsolete file)
I've built up muscle memory at this point where I click the bottom-most item in the menu to "set as bottom of range". With the new test-centric button now at the bottom of the menu, I've clicked it a few times already this morning.
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8854065 [details] [review] [treeherder] KWierso:testcentric > mozilla:master Other option: Move the menu item up a few entries, above "set as top of range"?
Attachment #8854065 -
Flags: review?(cdawson)
Comment 3•7 years ago
|
||
I think if the menu item has to be opt-in it might as well be deleted. As such I think the options really are: 1) Remove the menu item entirely 2) Move the menu item to somewhere not at the bottom 3) Wontfix and accept that muscle memory occasionally needs to be retrained My preference would be to decide where we'd put the link if it weren't "Experimental", and if that's the bottom then do #3, else #2. (I'm presuming at the moment it's at the bottom to keep experimental features separate, but I think moving it now is fine, since it will avoid future churn.)
Blocks: 1351092
Updated•7 years ago
|
Assignee: nobody → wkocher
Comment 4•7 years ago
|
||
Comment on attachment 8854065 [details] [review] [treeherder] KWierso:testcentric > mozilla:master I'd prefer one of the other options :-)
Attachment #8854065 -
Flags: review?(cdawson)
Assignee | ||
Comment 5•7 years ago
|
||
Philor, thoughts? I'm already no longer accidentally hitting the new menu item, so I'm happy leaving things unchanged unless it's still affecting your workflow.
Flags: needinfo?(philringnalda)
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(philringnalda)
Comment 6•7 years ago
|
||
Our current organization seems to be Thing used to add jobs ------------------- Thing used by sheriffs on mozilla-central and release branches to mark bugs ------------------- Three things used to add jobs ------------------- Two things used to control what pushes are shown ------------------- Experimental macOS HIG says to group similar and put frequently-used at the top, GNOME HIG says to group similar but being more geeky and thus more useful advice given Treeherder's market, also says that both the top and bottom are more noticeable and easier to hit and should be reserved for the most interesting and useful things (it's not just muscle-memory, it's about the fact that there are only two menuitem positions, first and last, that you can hit without having to aim much or read the text to be sure it's the one you want, so it's a shame to waste them). I'd say that means we should instead have Add new jobs BuildAPI Trigger missing jobs Trigger all Talos jobs Mark with Bugherder Experimental: Show the failing tests in the hidden Android WebGL suite Set as top of range Set as bottom of range which might also, by separating Bugherder and BuildAPI, cut down on the number of times that we've all sat staring at BuildAPI wondering why we opened it after merging to m-c.
Comment 7•7 years ago
|
||
Assignee | ||
Comment 8•7 years ago
|
||
Attachment #8854065 -
Attachment is obsolete: true
Assignee | ||
Comment 9•7 years ago
|
||
Comment on attachment 8858680 [details] [review] [treeherder] KWierso:menureorg > mozilla:master Here's philor's suggested menu order. I don't have a problem with it.
Attachment #8858680 -
Flags: feedback?(ryanvm)
Attachment #8858680 -
Flags: feedback?(cbook)
Attachment #8858680 -
Flags: feedback?(aryx.bugmail)
Assignee | ||
Updated•7 years ago
|
Attachment #8858681 -
Flags: feedback?(ryanvm)
Attachment #8858681 -
Flags: feedback?(cbook)
Attachment #8858681 -
Flags: feedback?(aryx.bugmail)
Assignee | ||
Updated•7 years ago
|
Attachment #8858680 -
Flags: feedback?(ryanvm)
Attachment #8858680 -
Flags: feedback?(cbook)
Attachment #8858680 -
Flags: feedback?(aryx.bugmail)
Comment 10•7 years ago
|
||
Comment on attachment 8858681 [details]
actionbuttonmenu.png
Fine with me.
Attachment #8858681 -
Flags: feedback?(ryanvm) → feedback+
Updated•7 years ago
|
Attachment #8858681 -
Flags: feedback?(aryx.bugmail) → feedback+
Assignee | ||
Updated•7 years ago
|
Summary: Make the test-centric menu item be opt-in. → Reorder thActionButton menu to make it easier to reach frequently used items.
Comment 11•7 years ago
|
||
Comment on attachment 8858681 [details]
actionbuttonmenu.png
fine with me
Attachment #8858681 -
Flags: feedback?(cbook) → feedback+
Assignee | ||
Updated•7 years ago
|
Attachment #8858680 -
Flags: review?(emorley)
Comment 12•7 years ago
|
||
Comment on attachment 8858680 [details] [review] [treeherder] KWierso:menureorg > mozilla:master r=me presuming you've tested locally :-)
Attachment #8858680 -
Flags: review?(emorley) → review+
Comment 13•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/3ea6fca6371545115d49c9ab85cced1328fd3446 Bug 1353065 - Rearrange thActionButton.html items (#2346) r=emorley
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•