1353093 - Expand GraphQL API to support Test-Group-Based UI

Status: RESOLVED FIXED

(Tree Management :: Treeherder: API, enhancement)

Description

[Cameron Dawson [:camd]]

We can use the GraphQL API syntax to support the test based UI.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:graphql-filtering > mozilla:master

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8854088 [details] [review]
[treeherder] mozilla:graphql-filtering > mozilla:master

Hey Will--  Are you up for reviewing this?  If you're on to other things, no problem.  Please reassign to Ed.  Thanks!  :)

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8854088 [details] [review]
[treeherder] mozilla:graphql-filtering > mozilla:master

I don't mind reviewing this, but it's probably better if Ed does it from the perspective of knowledge transfer.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d85b8f74d2bd63a7bd1de420aa15f422b360dbc8
Bug 1353093 - Add GraphQL filtering (#2313)

* Bug 1353093 - Update Graphene to the latest version

* Bug 1353093 - Allow parent models to reference children of foreign keys.

This is needed for the GraphQL / Graphene implementation to be able to
filter child fields.

* Bug 1353093 - Add filtering to Push, Job and JobDetail GraphQL elements

This is in support of the TestGroup Based UI for fetching the exact data we
need to display in a single query.

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:camd-patch-1 > mozilla:master

Comment 6

[Cameron Dawson [:camd]]

Comment on attachment 8856756 [details] [review]
[treeherder] mozilla:camd-patch-1 > mozilla:master

I wasn't able to just make this change without a PR.  I figure you could double-check it prior to merge?  Seems a bit circular since you actually wrote this code...  :)

Thanks again for all your help with this.

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8856756 [details] [review]
[treeherder] mozilla:camd-patch-1 > mozilla:master

Looks great! Many thanks :-)

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8181a778aad118fe507f1c4e3a55c5ea22709ab4
Bug 1353093 - Make migration 0008 a no-op (#2334)

Django bug https://code.djangoproject.com/ticket/28065 causes the
addition of ``related_name`` to create a migration that will drop and
re-add the foreign key.  However, this is a ``meta`` only change, so
no DB changes should be made and this ForeignKey drop and re-add
is super expensive.  I didn't notice this problem before I merged
commit d85b8f74d2bd63a7bd1de420aa15f422b360dbc8.