1353106 - Consecutive browser crash pings have empty ClientIds if its first crash is before the infobar is displayed

Status: RESOLVED WORKSFORME

(Toolkit :: Telemetry, defect, P1)

Description

[Abe - QA (:Abe_LV)]

Attachment: 0a245046-006b-42b7-a06b-e09c2b60e58f.json

Steps to Reproduce:

1. using the latest nightly, Set toolkit.telemetry.server;http://127.0.0.1:8080/
2. Stop your local Server if it is started. 
2. Crash the browser before the infobar displays. 
   Use addon: https://addons.mozilla.org/en-US/firefox/addon/crash-me-now-simple/
3. Restart the browser from Client Crash Reporter
4. Crash the browser again
5. Now, you should have a ping in the "Pending Pings" folder
6. Open the ping and check its ClientId. 

Actual Result:

ClientID is empty. 

Expected Result

ClientId should not be empty


Screen Capture: https://testing-1.tinytake.com/sf/MTQ3NjM4NF81MjA1MDYz

Comment 1

[Abe - QA (:Abe_LV)]

Correction to the above Step 4.
4. Wait until the infobar is displayed and then crash the browser again.

Comment 2

[Alessio Placitelli [:Dexter]]

(In reply to Abe - QA (:Abe_LV) from comment #1)
> Correction to the above Step 4.
> 4. Wait until the infobar is displayed and then crash the browser again.

Ok, so this is expected and *can* happen: Telemetry annotates the crash with the cached copy of the clientId which lives in the prefs ("toolkit.telemetry.cachedClientID").

This cached clientId gets created when Telemetry initializes, which is about 60 seconds after Firefox starts up. On the first run, this overlaps with when the "Data Choices" infobar is displayed. However, if you crash Firefox before 60s (so no Telemetry init and no data choice displayed on the first run), you will not get the client id cached. Moreover, on the next run, the "Data Choices" infobar will show up much earlier, after 10s. So if you crash Firefox after that, let's say 15s after Firefox starts up, you would still see an empty client id in the crash ping. That's because Telemetry would still init (and cache the client id) after 60s.

Here's a rundown of your test case:

> 1. using the latest nightly, Set
> toolkit.telemetry.server;http://127.0.0.1:8080/
> 2. Stop your local Server if it is started. 
> 2. Crash the browser before the infobar displays. 
>    Use addon:
> https://addons.mozilla.org/en-US/firefox/addon/crash-me-now-simple/

Here Telemetry isn't initialized, so no cached client id. Whoops, but expected.

> 3. Restart the browser from Client Crash Reporter
> 4. Wait until the infobar is displayed and then crash the browser again.

If you wait more than 60s before crashing it again, the newly generated ping will have the client id here.
If you crash before 60s, then the crash ping will not have the client id.

That's just supposed/expected to happen for crashes on new profiles that never-ever ran for more than 60s.

Abe, can you confirm that's the case?

Comment 3

[Abe - QA (:Abe_LV)]

>Abe, can you confirm that's the case?
Yes, this is the case.Please feel free to close this bug as invalid or something appropriate.