Make nsStringBuffer's reference count use the minimum memory synchronization needed

RESOLVED FIXED in Firefox 55

Status

()

Core
String
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This is the same optimization made for ThreadSafeAutoRefCnt in bug
1277709.  However, nsStringBuffer uses a 32-bit reference count all the
time, so it can't easily use ThreadSafeAutoRefCnt.

MozReview-Commit-ID: LpB3xaYbaEE
(Assignee)

Updated

a year ago
Component: XPCOM → String
(Assignee)

Comment 1

a year ago
Created attachment 8854185 [details] [diff] [review]
Make nsStringBuffer's reference count use the minimum memory synchronization needed

This is the same optimization made for ThreadSafeAutoRefCnt in bug
1277709.  However, nsStringBuffer uses a 32-bit reference count all the
time, so it can't easily use ThreadSafeAutoRefCnt.

MozReview-Commit-ID: LpB3xaYbaEE
Attachment #8854185 - Flags: review?(nfroyd)
Comment on attachment 8854185 [details] [diff] [review]
Make nsStringBuffer's reference count use the minimum memory synchronization needed

Review of attachment 8854185 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the comment in IsReadonly().
Attachment #8854185 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 4

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f0b34e87f26826fb65c9889d6d1f24fc6f200c
Bug 1353181 - Make nsStringBuffer's reference count use the minimum memory synchronization needed.  r=froydnj

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b6f0b34e87f2
https://hg.mozilla.org/mozilla-central/rev/19c4e80bee84
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.