1353185 - [geckoview] Allow GeckoViewExample to open arbitrary URIs

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, enhancement)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Just via the Intent. That way we can easily load whatever via 'adb shell am start'.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1353185 - Convert GeckoViewExample to use singleTop launch mode

Review commit: https://reviewboard.mozilla.org/r/126444/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126444/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8854491 [details]
Bug 1353185 - Convert GeckoViewExample to use singleTop launch mode

https://reviewboard.mozilla.org/r/126444/#review128984

Should probably also implement `onNewIntent` so you don't have to kill the activity everytime.

::: mobile/android/geckoview_example/src/main/AndroidManifest.xml:12
(Diff revision 1)
>  
>          <uses-library android:name="android.test.runner" />
>  
>          <activity android:name="org.mozilla.geckoview_example.GeckoViewActivity"
>                    android:label="GeckoViewActivity">
> -            <intent-filter>
> +            <intent-filter android:priority="999">

I don't think you need `android:priority="999"`

::: mobile/android/geckoview_example/src/main/AndroidManifest.xml:29
(Diff revision 1)
> +                <data android:scheme="http" />
> +                <data android:scheme="https" />
> +                <data android:scheme="about" />
> +                <data android:scheme="javascript" />
> +            </intent-filter>
> +            <intent-filter>

I think you can merge this into the previous <intent-filter>

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e521b2604a41
Open the passed-in URI in GeckoViewExample, if any r=jchen

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8854491 [details]
Bug 1353185 - Convert GeckoViewExample to use singleTop launch mode

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126444/diff/1-2/

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e521b2604a41

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/02ab056d454b
Convert GeckoViewExample to use singleTop launch mode r=jchen

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/02ab056d454b