Closed
Bug 1353189
Opened 7 years ago
Closed 7 years ago
Baldr: remove CodeSegment::vtune_method_id_
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
|
4.05 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
Looks like it's no longer needed in ~CodeSegment().
Attachment #8854189 -
Flags: review?(sstangl)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8854189 [details] [diff] [review] rm-method-id Review of attachment 8854189 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/vtune/VTuneWrapper.cpp @@ +132,5 @@ > printf("[!] VTune Integration: Failed to load method.\n"); > } > > void > +MarkWasm(unsigned methodId, const char* name, void* start, uintptr_t size) VTuneWrapper.cpp should also be able to remove the include of "wasm/WasmCode.h".
Attachment #8854189 -
Flags: review?(sstangl) → review+
Pushed by lwagner@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2a47268c3fdd Baldr: remove CodeSegment::vtune_method_id (r=sstangl)
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2a47268c3fdd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•