Don't display poop emoji on hg.mozilla.org for backed out csets

NEW
Unassigned

Status

Developer Services
Mercurial: hg.mozilla.org
8 months ago
8 months ago

People

(Reporter: jgilbert, Unassigned)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
It's already frustrating getting backed out. Adding little pictures of poop is uncalled for.

Updated

8 months ago
Blocks: 1171321
(Reporter)

Updated

8 months ago
Flags: needinfo?(gps)

Comment 1

8 months ago
Most people find the poop emoji to be amusing. And it does provide a purpose: calling attention to the fact that a changeset was backed out. What do you propose we replace it with?

Updated

8 months ago
Flags: needinfo?(gps)

Comment 2

8 months ago
Moving to the hg.mozilla.org component since this is unrelated to Treeherder.
Also tweaking summary, since the emoji is only in the web view, not added to the changeset metadata itself.

The code in question is here:
https://hg.mozilla.org/hgcustom/version-control-tools/file/ba73c94e8eb5/hgtemplates/gitweb_mozilla/changeset.tmpl#l36
Component: Treeherder → Mercurial: hg.mozilla.org
Product: Tree Management → Developer Services
Summary: Don't add poop emoji to backed out csets → Don't display poop emoji on hg.mozilla.org for backed out csets
Version: --- → unspecified

Comment 3

8 months ago
(In reply to Gregory Szorc [:gps] from comment #1)
> Most people find the poop emoji to be amusing. And it does provide a
> purpose: calling attention to the fact that a changeset was backed out. What
> do you propose we replace it with?

Possible alternate emoji suggestions: ⚠️

Comment 4

8 months ago
(In reply to Ian Moody [:Kwan] from comment #3)
> (In reply to Gregory Szorc [:gps] from comment #1)
> > Most people find the poop emoji to be amusing. And it does provide a
> > purpose: calling attention to the fact that a changeset was backed out. What
> > do you propose we replace it with?
> 
> Possible alternate emoji suggestions: ⚠️

Urgh, well bugzilla ate that with no warning in the preview.
My suggestions were:
U+26A0 Warning Sign
U+1F519 Back With Leftwards Arrow Above
U+2620 Skull and Crossbones
U+1F571 Black Skull and Crossbones
U+1F525 Fire

Comment 5

8 months ago
Created attachment 8854228 [details]
original-comment.png

Here's what my comment was supposed to look like. I wonder if U+26A0 Warning Sign and U+2620 Skull and Crossbones being below U+10000 might be an advantage.

Comment 6

8 months ago
Yeah, Bugzilla eats all text after first emoji. IIRC MySQL is to blame.

I like one of the skull and crossbones or fire. If those are well supported in browsers, I'll r+ a patch.
(In reply to Gregory Szorc [:gps] from comment #6)
> Yeah, Bugzilla eats all text after first emoji. IIRC MySQL is to blame.

FWIW, relevant bug: bug 1253535
fire and tree? ala https://pageshot.net/7Z4jqVPzNqqJZh3p/emojikeyboard.org
(Reporter)

Comment 9

8 months ago
Honestly, making the text background red would be perfect.
I know people feel that emoji are fun, but it matters first that this is practical. A big red bar at the top would make it obvious something's wrong.
You need to log in before you can comment on or make changes to this bug.