Closed
Bug 1353264
Opened 7 years ago
Closed 7 years ago
Intermittent toolkit/components/telemetry/tests/unit/test_ThreadHangStats.js | check_results - [check_results : 91] false == true
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla56
People
(Reporter: intermittent-bug-filer, Assigned: nika)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.50 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=88485359&repo=autoland https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win64/1491272127/autoland_win8_64_test-xpcshell-bm126-tests1-windows-build511.txt.gz
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 6•7 years ago
|
||
This appears to have gone permafail since Gecko 56 was uplifted to Beta yesterday. Any ideas as to what might be going wrong? https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1353264&startday=2017-08-02&tree=mozilla-beta
Assignee | ||
Comment 7•7 years ago
|
||
We don't collect native stacks in beta builds :-S. That part of the test should just be disabled in beta builds. Should I just make a patch to delete that part of the test? The entire test is going to be replaced by bug 1380081, so the problem won't come up again next uplift.
Flags: needinfo?(michael)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → michael
Comment 8•7 years ago
|
||
Yes, a patch removing the problematic section sounds great! I'll land it a=test-only as soon as it's ready :)
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 10•7 years ago
|
||
This should do it. MozReview-Commit-ID: 4Ssxa3iUcHK
Assignee | ||
Comment 11•7 years ago
|
||
Comment on attachment 8893822 [details] [diff] [review] Disable testing native stack collection in beta We don't collect native stacks in beta right now, so the test was wrong. This patch just removes the problematic section, and the whole test is going away in bug 1380081 for nightly, so it won't be in the next uplift.
Attachment #8893822 -
Flags: review?(nfroyd)
Comment 12•7 years ago
|
||
Comment on attachment 8893822 [details] [diff] [review] Disable testing native stack collection in beta Review of attachment 8893822 [details] [diff] [review]: ----------------------------------------------------------------- Didn't realize this was necessary to get beta greened up!
Attachment #8893822 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 13•7 years ago
|
||
Comment on attachment 8893822 [details] [diff] [review] Disable testing native stack collection in beta Approval Request Comment [Feature/Bug causing the regression]: N/A [User impact if declined]: Incorrect test failures on beta. [Is this code covered by automated tests?]: Fix to automated test [Has the fix been verified in Nightly?]: N/A [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Test only change [String changes made/needed]: None
Attachment #8893822 -
Flags: approval-mozilla-beta?
Comment 14•7 years ago
|
||
Comment on attachment 8893822 [details] [diff] [review] Disable testing native stack collection in beta It's a test-only change. I'll get it uplifted later today :) Thanks for the quick response!
Attachment #8893822 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
status-firefox55:
--- → wontfix
Whiteboard: [checkin-needed-beta]
Comment 15•7 years ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/3b4cf744da12
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed-beta]
Target Milestone: --- → mozilla56
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•