Closed Bug 1353299 Opened 2 years ago Closed 2 years ago

make sure to invalidate when composited frame becomes valid

Categories

(Core :: ImageLib, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file, 1 obsolete file)

If the composited frame goes from being invalid (we draw nothing) to valid (we draw something) we should invalidate. Most cases there will be an invalidate for whatever change caused the composited frame to become valid, but not always.
Attached patch patch (obsolete) — Splinter Review
Attachment #8854361 - Flags: review?(aosmond)
Attached patch patch v2Splinter Review
Attachment #8854361 - Attachment is obsolete: true
Attachment #8854361 - Flags: review?(aosmond)
Attachment #8854779 - Flags: review?(aosmond)
Comment on attachment 8854779 [details] [diff] [review]
patch v2

Review of attachment 8854779 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/RasterImage.cpp
@@ +1730,3 @@
>    }
>  
> +

nit: remove extra blank line
Attachment #8854779 - Flags: review?(aosmond) → review+
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b4e96304c8d
Make sure to invalidate when composited frame becomes valid. r=aosmond
https://hg.mozilla.org/mozilla-central/rev/8b4e96304c8d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.