make sure to invalidate when composited frame becomes valid

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
If the composited frame goes from being invalid (we draw nothing) to valid (we draw something) we should invalidate. Most cases there will be an invalidate for whatever change caused the composited frame to become valid, but not always.
(Assignee)

Comment 1

2 years ago
Created attachment 8854361 [details] [diff] [review]
patch
Attachment #8854361 - Flags: review?(aosmond)
(Assignee)

Comment 2

2 years ago
Created attachment 8854779 [details] [diff] [review]
patch v2
Attachment #8854361 - Attachment is obsolete: true
Attachment #8854361 - Flags: review?(aosmond)
Attachment #8854779 - Flags: review?(aosmond)
Comment on attachment 8854779 [details] [diff] [review]
patch v2

Review of attachment 8854779 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/RasterImage.cpp
@@ +1730,3 @@
>    }
>  
> +

nit: remove extra blank line
Attachment #8854779 - Flags: review?(aosmond) → review+

Comment 4

2 years ago
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b4e96304c8d
Make sure to invalidate when composited frame becomes valid. r=aosmond

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8b4e96304c8d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.