1353328 - Keep a memory cache of the last N stored favicons

Status: NEW

(Toolkit :: Places, enhancement, P3)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

It's likely multiple consecutive page visits will reuse icons from previous ones, so it sounds useful to have a small cache of the last set icons and directly skip a read from the database when we know the icon has been recently stored.
There is a downside though, pages could be removed from the database (history removals) and that should somehow invalidate the cache.
If the cache lives in the async thread, we could probably use a trigger. But we should first fix bug 1249263 so that there's no left synchronous way to remove history.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

(In reply to Marco Bonardo [::mak] from comment #0)
> It's likely [we should cache favicons in memory]

It sounds like this would be worth measuring before actually doing it, because...

> There is a downside though

Yeah, that's a big downside - and it's not obvious to me the complexity and memory cost is worth solving a problem that doesn't necessarily exist in terms of actual user experience.

IOW, I think we should see if we can leverage telemetry to see if the favicon-fetch latency really is of concern before we optimize this.