Closed Bug 1353329 Opened 3 years ago Closed 2 years ago

Remove the SecureElement API

Categories

(Core :: DOM: Device Interfaces, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: hsivonen, Assigned: adrian17)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

SecureElement and SecureElementManager are chrome-only and always preffed off. They were added in bug 879861 for Firefox OS.

We should remove them, since they aren't in use.
Keywords: good-first-bug
Priority: -- → P3
Assignee: nobody → kyle
Would love to give this a shot if someone can tell me how to get started!
Flags: needinfo?(hsivonen)
(In reply to nikshepsvn from comment #1)
> Would love to give this a shot if someone can tell me how to get started!

Search for SecureElement and SecureElementManager in the codebase and remove them. Then fix things until the code compiles again.
Flags: needinfo?(hsivonen)
Comment on attachment 8947232 [details]
Bug 1353329 - Remove remains of SecureElement API.

https://reviewboard.mozilla.org/r/216986/#review222850

r=me.  Thank you for picking this up!
Attachment #8947232 - Flags: review?(bzbarsky) → review+
Did you run this through try already?
Flags: needinfo?(adrian.wielgosik)
Assignee: kyle → adrian.wielgosik
Thank you!  I triggered autolanding.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/331af427e379
Remove remains of SecureElement API. r=bz
https://hg.mozilla.org/mozilla-central/rev/331af427e379
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.