1353349 - Blank view when trying to retrieve profile; console shows "TypeError: e.meta is undefined"

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Lars T Hansen [:lth]]

When typing Ctrl-Shift-2 to retrieve the profile a new tab is shown with the text "Retrieving profile from the gecko profiler addon..." at the top and nothing else.  The page is never filled in.

The console shows this text:

  TypeError: e.meta is undefined  ... 930ab849cc46f3f9ae82.bundle.js:28:6949
  Successfully compiled asm.js code (loaded from cache in 4ms)  zee-worker.js

This is in Dev Ed 54 and Nightly 55, both up-to-date as of today and Gecko Profiler installed today.  Mac OS X 10.12.3, "late 2013" MBP, lots of RAM.

Comment 1

[Markus Stange [:mstange]]

Does the problem go away if you reload the perf-html.io tab?

Comment 2

[Lars T Hansen [:lth]]

(In reply to Markus Stange [:mstange] from comment #1)
> Does the problem go away if you reload the perf-html.io tab?

It does not.

Comment 3

[Lars T Hansen [:lth]]

And I did have an adblocker enabled early on, but I've since disabled that.  My Nightly profile only has the Gecko Profiler, uBlock Origin, and Duplicate In Tab Context Menu extensions.

Comment 4

[Markus Stange [:mstange]]

I don't know what might be causing this. May I ask you to do some debugging using a development version of perf.html? You can follow the steps on https://github.com/devtools-html/perf.html#development to launch your own instance locally and point the add-on at it.

Comment 5

[Lars T Hansen [:lth]]

Will try to find some time this week for that.  Thanks.

Comment 6

[Greg Tatum [:gregtatum]]

I ran into this same issue a few days ago. In the development version it was `profile.meta`. I believe the profile we got from the Gecko Profiler Addon was a blank object `{}`.

Comment 7

[Markus Stange [:mstange]]

I've now hit this a few times myself. It looks like the platform is generating invalid JSON, failing to parse it, and then returning an empty object from getProfileDataAsync().

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1353349 - Don't attempt to put empty profiles into the processes array.

Review commit: https://reviewboard.mozilla.org/r/137616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137616/

Comment 9

[Nathan Froyd [:froydnj]]

Comment on attachment 8866023 [details]
Bug 1353349 - Don't attempt to put empty profiles into the processes array.

https://reviewboard.mozilla.org/r/137616/#review140738

Willing to say this is a good thing, though it doesn't fix the issue I'm seeing.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dba495fc3c06
Don't attempt to put empty profiles into the processes array. r=froydnj

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dba495fc3c06

Comment 12

[YF (Yang)]

I meet this issue in Fx55b1 x64 on Win10 now, I once encountered it in Nightly 55 and it once gone away.