1353380 - Add tests for show/hide more columns in the network panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P1)

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1353380 - Add tests for hiding/showing columns.

Review commit: https://reviewboard.mozilla.org/r/126792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126792/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8854839 [details]
Bug 1353380 - Add tests for hiding/showing columns.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126792/diff/1-2/

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8854839 [details]
Bug 1353380 - Add tests for hiding/showing columns.

https://reviewboard.mozilla.org/r/126792/#review129432

LGTM! There are not so much things I can add. Thanks!

::: devtools/client/netmonitor/test/browser_net_columns_last_column.js:20
(Diff revision 2)
> +
> +  for (let [column, shown] of gStore.getState().ui.columns) {
> +    let visibleColumns = [...gStore.getState().ui.columns]
> +      .filter(([_, visible]) => visible);
> +
> +    if (visibleColumns.length == 1) {

nit: use ===

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8854839 [details]
Bug 1353380 - Add tests for hiding/showing columns.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126792/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9968cea4fc7d
Add tests for hiding/showing columns. r=rickychien

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9968cea4fc7d