Closed Bug 1353380 Opened 5 years ago Closed 5 years ago

Add tests for show/hide more columns in the network panel

Categories

(DevTools :: Netmonitor, enhancement, P1)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Iteration:
55.3 - Apr 17
Tracking Status
firefox55 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

(Whiteboard: [netmonitor-reserve])

Attachments

(1 file)

No description provided.
Whiteboard: [netmonitor][triage]
Flags: qe-verify-
Priority: -- → P3
Summary: Add tests for bug 862855 → Add tests for bug 862855 (show/hide more columns in the network panel)
Whiteboard: [netmonitor][triage] → [netmonitor-reserve]
Summary: Add tests for bug 862855 (show/hide more columns in the network panel) → Add tests for show/hide more columns in the network panel
Assignee: nobody → ntim.bugs
Comment on attachment 8854839 [details]
Bug 1353380 - Add tests for hiding/showing columns.

https://reviewboard.mozilla.org/r/126792/#review129432

LGTM! There are not so much things I can add. Thanks!

::: devtools/client/netmonitor/test/browser_net_columns_last_column.js:20
(Diff revision 2)
> +
> +  for (let [column, shown] of gStore.getState().ui.columns) {
> +    let visibleColumns = [...gStore.getState().ui.columns]
> +      .filter(([_, visible]) => visible);
> +
> +    if (visibleColumns.length == 1) {

nit: use ===
Attachment #8854839 - Flags: review?(rchien) → review+
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9968cea4fc7d
Add tests for hiding/showing columns. r=rickychien
https://hg.mozilla.org/mozilla-central/rev/9968cea4fc7d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Iteration: --- → 55.3 - Apr 17
Priority: P3 → P1
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.