1353502 - nsContentUtils::RemoveScriptBlocker() shouldn't have diagnostic asserts

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

http://searchfox.org/mozilla-central/rev/381a7b8f8a78b481336cfa384cb0a5536e217e4a/dom/base/nsContentUtils.cpp#5329 shows up in all the DOM profiles.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: no_diagnostic_assert_in_super_hot_code_path.diff

The diagnostic assert makes profiling Nightly more difficult.
And I haven't seen it catching any issues ever.
I do assume we crash anyhow very quickly if one is using script blockers off the main thread

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

And commit message could be

-m "Bug 1353502 - nsContentUtils::RemoveScriptBlocker() shouldn't have diagnostic asserts since such show up in performance profiles, r=qDot"

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c0d3fedaa67
nsContentUtils::RemoveScriptBlocker() shouldn't have diagnostic asserts since such show up in performance profiles, r=qDot

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1c0d3fedaa67