Closed
Bug 1353537
Opened 9 years ago
Closed 9 years ago
adb.py push fails to push directory containing links
Categories
(Testing :: Mozbase, enhancement)
Testing
Mozbase
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bc, Assigned: gbrown)
References
Details
Attachments
(1 file)
|
2.44 KB,
patch
|
bc
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1285040 +++
Let's track this separately and get it landed so we can release a new version of mozbase with it included.
|
Assignee | |
Comment 1•9 years ago
|
||
This should be just like the devicemanager change in bug 1346083, except it is a little different because adb's push() can push a file or directory.
Attachment #8854604 -
Flags: review?(bob)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Pretty sure you cloned the wrong bug.
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8854604 [details] [diff] [review]
copy directory when pushing directory, to allow for links
r+. lgtm. tested autophone with adb 1.0.32 and 1.0.36 and it looks good.
Attachment #8854604 -
Flags: review?(bob) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/141975d40a7c
Update adb.py push() to always copy directories when pushing a directory; r=bc
|
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
Reporter | |
Comment 6•9 years ago
|
||
gbrown: Could you go ahead and push this to autophone as well?
Flags: needinfo?(gbrown)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Flags: needinfo?(gbrown)
You need to log in
before you can comment on or make changes to this bug.
Description
•