adb.py push fails to push directory containing links

RESOLVED FIXED in Firefox 55

Status

Testing
Mozbase
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: bc, Assigned: gbrown)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
+++ This bug was initially created as a clone of Bug #1285040 +++

Let's track this separately and get it landed so we can release a new version of mozbase with it included.
(Assignee)

Updated

11 months ago
No longer blocks: 1284560
(Assignee)

Comment 1

11 months ago
Created attachment 8854604 [details] [diff] [review]
copy directory when pushing directory, to allow for links

This should be just like the devicemanager change in bug 1346083, except it is a little different because adb's push() can push a file or directory.
Attachment #8854604 - Flags: review?(bob)
(Assignee)

Comment 2

11 months ago
Pretty sure you cloned the wrong bug.
Depends on: 1346083
No longer depends on: 1285040
Summary: adb.py push pushes to sub-directory with latest adb → adb.py push fails to push directory containing links
(Reporter)

Comment 3

11 months ago
Comment on attachment 8854604 [details] [diff] [review]
copy directory when pushing directory, to allow for links

r+. lgtm. tested autophone with adb 1.0.32 and 1.0.36 and it looks good.
Attachment #8854604 - Flags: review?(bob) → review+

Comment 4

11 months ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/141975d40a7c
Update adb.py push() to always copy directories when pushing a directory; r=bc

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/141975d40a7c
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Reporter)

Comment 6

11 months ago
gbrown: Could you go ahead and push this to autophone as well?
Flags: needinfo?(gbrown)
You need to log in before you can comment on or make changes to this bug.