prevent MSI installer to install TB on Windows Vista or lower

RESOLVED FIXED in Thunderbird 55.0

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 55.0
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

6.33 KB, patch
mkmelin
: review+
clokep
: review+
Details | Diff | Splinter Review
(Assignee)

Description

2 years ago
Now that Windows XP and Vista are not supported, the NSIS installer was updated to prevent installing on them. It seems the MSI installer still would allow it. I don't know if that installer even works, but let's be on the safe side.
(Assignee)

Comment 1

2 years ago
Created attachment 8854595 [details] [diff] [review]
patch

This increases the Win versions checks for TB and IM. I can't test it as I am not on Windows, but the try servers seem unaffected: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4aed5e5a3b6c201578454d9274d52d346e7b6795
Even considering they build on XP, but then run on Win 7.
Attachment #8854595 - Flags: review?(mkmelin+mozilla)
Attachment #8854595 - Flags: review?(clokep)
Is this a port of a Firefox bug?
FX has no msi directory. Maybe we should delete it as well.
(Assignee)

Comment 4

2 years ago
Yeah, no such code in Firefox. I don't think we even have a msi installer (I'm not sure if even Firefox had one).
Maybe those files/dirs are useless.
Comment on attachment 8854595 [details] [diff] [review]
patch

Review of attachment 8854595 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, better to just remove them as that is unused
Attachment #8854595 - Flags: review?(mkmelin+mozilla)
Attachment #8854595 - Flags: review?(clokep)
(Assignee)

Comment 6

2 years ago
Created attachment 8855028 [details] [diff] [review]
patch v2

Ok.
Attachment #8854595 - Attachment is obsolete: true
Attachment #8855028 - Flags: review?(mkmelin+mozilla)
Attachment #8855028 - Flags: review?(clokep)
Comment on attachment 8855028 [details] [diff] [review]
patch v2

Review of attachment 8855028 [details] [diff] [review]:
-----------------------------------------------------------------

Great! r=mkmelin
Attachment #8855028 - Flags: review?(mkmelin+mozilla) → review+
Attachment #8855028 - Flags: review?(clokep) → review+
(Assignee)

Comment 8

2 years ago
Thanks.
Keywords: checkin-needed

Comment 9

2 years ago
https://hg.mozilla.org/comm-central/rev/c75889c6b37d8e8ea7e4ac1671c60404552e1a0d
Thanks for your contribution ;-)

Did you know that |hg qimport bz: ...| destroys patches that contain CR/LF like this one?
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
(Assignee)

Comment 10

2 years ago
No, I never noticed as I never use the bz: prefix.
You need to log in before you can comment on or make changes to this bug.