1353540 - prevent MSI installer to install TB on Windows Vista or lower

Status: RESOLVED FIXED

(Thunderbird :: Installer, enhancement)

Description

[:aceman]

Now that Windows XP and Vista are not supported, the NSIS installer was updated to prevent installing on them. It seems the MSI installer still would allow it. I don't know if that installer even works, but let's be on the safe side.

Comment 1

[:aceman]

Attachment: patch

This increases the Win versions checks for TB and IM. I can't test it as I am not on Windows, but the try servers seem unaffected: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4aed5e5a3b6c201578454d9274d52d346e7b6795
Even considering they build on XP, but then run on Win 7.

Comment 2

[Patrick Cloke [:clokep]]

Is this a port of a Firefox bug?

Comment 3

[Richard Marti (:Paenglab)]

FX has no msi directory. Maybe we should delete it as well.

Comment 4

[:aceman]

Yeah, no such code in Firefox. I don't think we even have a msi installer (I'm not sure if even Firefox had one).
Maybe those files/dirs are useless.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8854595 [details] [diff] [review]
patch

Review of attachment 8854595 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, better to just remove them as that is unused

Comment 6

[:aceman]

Attachment: patch v2

Ok.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 8855028 [details] [diff] [review]
patch v2

Review of attachment 8855028 [details] [diff] [review]:
-----------------------------------------------------------------

Great! r=mkmelin

Comment 8

[:aceman]

Thanks.

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/c75889c6b37d8e8ea7e4ac1671c60404552e1a0d
Thanks for your contribution ;-)

Did you know that |hg qimport bz: ...| destroys patches that contain CR/LF like this one?

Comment 10

[:aceman]

No, I never noticed as I never use the bz: prefix.