Closed Bug 1353565 Opened 3 years ago Closed 3 years ago

Label snow white killer as SystemGroup

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
I pushed this to try and it passes. The danger here is that destructors could touch DOM or run non-chrome JS. I talked to Olli about this and I don't think there's much we can do besides watch to see if it asserts. So far it looks okay.
Attachment #8854631 - Flags: review?(continuation)
Comment on attachment 8854631 [details] [diff] [review]
patch

Review of attachment 8854631 [details] [diff] [review]:
-----------------------------------------------------------------

I'm surprised we don't run any content JS from destructors, but I guess if try is green it must not be as bad as I thought.
Attachment #8854631 - Flags: review?(continuation) → review+
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbc166e6fe86
Label snow white killer as SystemGroup (r=mccr8)
https://hg.mozilla.org/mozilla-central/rev/cbc166e6fe86
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.