Closed Bug 1353634 Opened 4 years ago Closed 4 years ago
Fix the -Wmisleading-indentation warnings
No description provided.
Just indentation changes
Assignee: nobody → sledru
Interesting, two questions: 1) Did you do the changes by hand? 2) Where do those warnings come from? I recently worked here https://hg.mozilla.org/comm-central/rev/2967d03cf5bc66717e3ff62ece9fc94faeae45e6#l1.24 and I had to control myself not to fix all the indentation issues I saw there.
Comment on attachment 8854716 [details] [diff] [review] bug.diff I "tested" your patch by going patch < .hg/patches/bug.diff followed by a hg diff -w That showed no differences. I also inspected it visually. Anyway, I'd like to know the background of this and why you processed these files and not others.
Attachment #8854716 - Flags: review?(jorgk) → review+
https://hg.mozilla.org/comm-central/rev/40564785c448d8bc38a3edac62e6cc54e0e55a61 Bug 1353634 - Fix the -Wmisleading-indentation warnings r=jorgk
Thanks > 1) Did you do the changes by hand? Yes > 2) Where do those warnings come from? recent version of gcc clang-tidy also provides this check: http://clang.llvm.org/extra/clang-tidy/checks/readability-misleading-indentation.html
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.