1353647 - Fix the inconsistency result of custom element v0 upgrade

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Edgar Chen [:edgar]]

This bug is filed from bug 1299363 comment #68.

There are two places doing prototype setup in old upgrade,
- If definition comes after JS reflector creation, CustomElementRegistry::Upgrade will do prototype swizzling. 
- If definition comes before JS reflector creation, Element::WrapObject will set up the prototype. 

The later one does SubsumesConsideringDomain, but the former doesn't not.

Although bug 1299363 might also touch these code, but bug 1299363 is to implement new upgrade steps, I would like to NOT change any behavour of old upgrade there, so fix the inconsistency here instead.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Comment 3

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8dfa2264cdf211da6395789fb1432d79f6aab312&filter-tier=1&group_state=expanded

Comment 4

[Edgar Chen [:edgar]]

Comment on attachment 8854780 [details] [diff] [review]
Patch, v2

Review of attachment 8854780 [details] [diff] [review]:
-----------------------------------------------------------------

Hi William, could you help to review this? Thank you.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/717072f9f2c6
Fix the custom elements v0 upgrade inconsistency; r=wchen

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/717072f9f2c6