build/unix/elfhack/inject can build things during export before libclang-plugin.so is built

RESOLVED FIXED in Firefox 55

Status

Firefox Build System
General
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla55

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I got an interesting race condition on try involving the export rule in build/unix/elfhack/inject. I actually don't see a reason why the sources there are built during export...
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8854764 [details]
Bug 1353661 - Don't build elfhack/inject during export.

https://reviewboard.mozilla.org/r/126732/#review129634
Attachment #8854764 - Flags: review?(mshal) → review+

Comment 3

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/6d4989ca4f59
Don't build elfhack/inject during export. r=mshal

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6d4989ca4f59
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.