Closed
Bug 1353663
Opened 8 years ago
Closed 8 years ago
Don't bother with typedef in nsGridContainerFrame::BuildDisplayList
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
INVALID
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | affected |
People
(Reporter: dholbert, Unassigned)
Details
We have a typedef in nsGridContainerFrame::BuildDisplayList which seems intended to make a line shorter -- but the line ends up going over 80 characters anyway.
And if we rewrap the line such that it doesn't go over 80 characters, then it's short enough that it doesn't benefit from the typedef.
So: let's just get rid of the typedef & rewrap the line more nicely.
(I ran across this while cribbing from this code in flexbox, over on bug 812687. I'm spinning off this minor grid fixup into its own bug because I'm hoping to uplift bug 812687, but there's no need to uplift this stylistic fix.)
|
Reporter | |
Comment 1•8 years ago
|
||
Sorry, my bad; we do need the typedef after all. We use it on the subsequent lines below the one I was focusing on.
I might push a no-bug whitespace fixup to rewrap the too-long-line at some point, but for now I'll just close this bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
|
|
Reporter | |
Updated•8 years ago
|
Assignee: dholbert → nobody
You need to log in
before you can comment on or make changes to this bug.
Description
•