1353690 - ASI not applied for "let <linebreak> await" in async functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[André Bargull [:anba]]

Test case:
---
async function f() {
    let
    await 0;
}
---

Expected: No SyntaxError
Actual: Reports a SyntaxError

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Saw this float by in bugmail, figured it'd be a simple patch, decided it was a good time to learn about how |await| keyword handling words.

Comment 2

[Shu-yu Guo [:shu]]

Comment on attachment 8855064 [details] [diff] [review]
Patch

Review of attachment 8855064 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Could you convert that test to a test262 test instead? What I've been doing is:

1. Add the test to test262/local
2. Open a PR upstream.
3. Remove the test262/local file when test262 is synced against a rev where the PR has been merged.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5001c15f9ec3
Properly exclude |await| from consideration as a |let| variable name in async functions, so that a newline between the two separates them into two distinct expressions.  r=shu

Comment 4

[Jeff Walden [:Waldo]]

(In reply to Shu-yu Guo [:shu] from comment #2)
> 2. Open a PR upstream.

https://github.com/tc39/test262/pull/956

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5001c15f9ec3