1353692 - Don't allow function closure syntax for async functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[André Bargull [:anba]]

Test case:
---
void async function()0;
---

Expected: Throws SyntaxError
Actual: No SyntaxError

Comment 1

[André Bargull [:anba]]

Attachment: bug1353692.patch

Moved the check into the |if (kind != Arrow) { ... }| block, so we don't need to special case async arrow-functions.

Also removed the PropertyType::Constructor/PropertyType::DerivedConstructor checks from Parser::classDefinition() because Parser::propertyName() never sets |propType| to PropertyType::Constructor/PropertyType::DerivedConstructor.

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8855392 [details] [diff] [review]
bug1353692.patch

Review of attachment 8855392 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=49781ea1c0a8f060b4e0ee79304bf64eafea159c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45d48a852a0c
Don't allow function expression closure syntax for async functions. r=arai

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/45d48a852a0c

Comment 6

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Expression_closures#Compatibility_notes
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function#Firefox-specific_notes