1353699 - Default font dropdown list becomes empty if Advanced dialog is set to "default" font from other font

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

STR:
1. Open "Option"
2. Open "Advanced" dialog of font configuration.
3. Select its default serif or sans-serif font to a specific font (i.e., not "default").
4. Close the dialog, then, the dropdown list should be changed to the selected font.
5. Open "Advanced" dialog again.
6. Select the default serif or sans-serif font to "default".
7. Close the dialog.

Actual Result:
The dropdown list becomes empty.

Expected Result:
The dropdown list should select the "default" font.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fd213025c84fdb252a73ca2487587a886daec51

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1353699 <menulist> for default font should use onsyncfrompreference

When font.name.*.* is set to false, "value" attribute of <preference> is removed.  Then, <preference>.setElementValue() with an element which doesn't have onsyncfrompreference tries to set null.  Then, <menulist> selects nothing.

In such case, <menulist> should select the item whose value is "". If there is onsyncfrompreference attribute and it returns empty string, <preference>.setElementValue()  works as expected.

Review commit: https://reviewboard.mozilla.org/r/126872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126872/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8854956 [details]
Bug 1353699 <menulist> for default font should use onsyncfrompreference

https://reviewboard.mozilla.org/r/126872/#review129550

Please make the same changes to in-content-old/content.{js,xul}.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Sorry, in comment 3 I should have included a link to more explanation of in-content-old: https://mail.mozilla.org/pipermail/firefox-dev/2017-March/005211.html

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd7fd86fb7f3f8cfc94e1f493d218c5694f21fa5

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8854956 [details]
Bug 1353699 <menulist> for default font should use onsyncfrompreference

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126872/diff/1-2/

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8854956 [details]
Bug 1353699 <menulist> for default font should use onsyncfrompreference

https://reviewboard.mozilla.org/r/126872/#review129810

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b682ad068ee3
<menulist> for default font should use onsyncfrompreference r=jaws

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b682ad068ee3

Comment 10

[Md.Tarikul Islam Oashi]

I have to reproduced this bug with Nightly 55.0a1 (2017-04-05) on Windows 7 64 bit;

The Bug's fix is verified on Latest Nightly 55.0a1

Build ID 	20170427030231
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[Testday-20170428]