1353716 - Netmonitor header context menu should appear even by right clicking a blank area of the header

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Tim Nguyen :ntim]

STR:
- Hide the waterfall/timeline column
- Right-click the white space that's left by the column

AR:
- nothing happens

ER:
- Context menu should show up.

Comment 1

[Abhinav Koppula]

Attachment: Bug 1353716 - Netmonitor header context menu should appear even by right clicking a blank area of the header.

Review commit: https://reviewboard.mozilla.org/r/198864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198864/

Comment 2

[Abhinav Koppula]

Hi Honza,
I have fixed the above issue and have added a small test for it as well.
Can you check once?

Comment 3

[Abhinav Koppula]

Comment on attachment 8927560 [details]
Bug 1353716 - Netmonitor header context menu should appear even by right clicking a blank area of the header.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198864/diff/1-2/

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8927560 [details]
Bug 1353716 - Netmonitor header context menu should appear even by right clicking a blank area of the header.

https://reviewboard.mozilla.org/r/198864/#review204140

Thanks for the patch Abhinav!

R+, assuming my comment is resolved and try is green.

Honza

::: devtools/client/netmonitor/src/components/RequestListHeader.js:110
(Diff revision 2)
>  
>      return (
>        div({ className: "devtools-toolbar requests-list-headers-wrapper" },
> -        div({ className: "devtools-toolbar requests-list-headers" },
> +        div({
> +          className: "devtools-toolbar requests-list-headers",
> +          onContextMenu: this.onContextMenu

I think you can remove the original `onContextMenu` handler in request list header box.

Comment 5

[Abhinav Koppula]

Comment on attachment 8927560 [details]
Bug 1353716 - Netmonitor header context menu should appear even by right clicking a blank area of the header.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198864/diff/2-3/

Comment 6

[Abhinav Koppula]

Comment on attachment 8927560 [details]
Bug 1353716 - Netmonitor header context menu should appear even by right clicking a blank area of the header.

https://reviewboard.mozilla.org/r/198864/#review204140

Hi Honza,
Thanks for the review. I have addressed the review-comment.

Comment 7

[Abhinav Koppula]

TRY push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=526d1326eb2201080bc0652e9ea62eef95efa937

Comment 8

[Abhinav Koppula]

(In reply to Abhinav Koppula from comment #7)
> TRY push:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=526d1326eb2201080bc0652e9ea62eef95efa937

The summary of the above TRY didn't show up bug specific commit. So pushed again,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d29054cf3a2a6c907f323a0a6079d68c2db5f7bc

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d99b84c4820
Netmonitor header context menu should appear even by right clicking a blank area of the header. r=Honza

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7d99b84c4820

Comment 11

[Adrian Florinescu [:aflorinescu]]

Reproduced the issue on v 59.0a1 20171116220410. 
Verified the fix using 59.0a1 20171211105838   on Windows 10 x64, MacOsx 10.5.5, Ubuntu 17.04x64