Closed Bug 1353716 Opened 3 years ago Closed 2 years ago

Netmonitor header context menu should appear even by right clicking a blank area of the header

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(firefox59 verified)

VERIFIED FIXED
Firefox 59
Tracking Status
firefox59 --- verified

People

(Reporter: ntim, Assigned: abhinav.koppula)

References

Details

(Whiteboard: [netmonitor-reserve])

Attachments

(1 file)

STR:
- Hide the waterfall/timeline column
- Right-click the white space that's left by the column

AR:
- nothing happens

ER:
- Context menu should show up.
Flags: qe-verify?
Whiteboard: [netmonitor][triage]
Flags: qe-verify? → qe-verify+
Priority: -- → P3
Whiteboard: [netmonitor][triage] → [netmonitor-reserve]
QA Contact: ciprian.georgiu
Hi Honza,
I have fixed the above issue and have added a small test for it as well.
Can you check once?
Comment on attachment 8927560 [details]
Bug 1353716 - Netmonitor header context menu should appear even by right clicking a blank area of the header.

https://reviewboard.mozilla.org/r/198864/#review204140

Thanks for the patch Abhinav!

R+, assuming my comment is resolved and try is green.

Honza

::: devtools/client/netmonitor/src/components/RequestListHeader.js:110
(Diff revision 2)
>  
>      return (
>        div({ className: "devtools-toolbar requests-list-headers-wrapper" },
> -        div({ className: "devtools-toolbar requests-list-headers" },
> +        div({
> +          className: "devtools-toolbar requests-list-headers",
> +          onContextMenu: this.onContextMenu

I think you can remove the original `onContextMenu` handler in request list header box.
Attachment #8927560 - Flags: review?(odvarko) → review+
Comment on attachment 8927560 [details]
Bug 1353716 - Netmonitor header context menu should appear even by right clicking a blank area of the header.

https://reviewboard.mozilla.org/r/198864/#review204140

Hi Honza,
Thanks for the review. I have addressed the review-comment.
(In reply to Abhinav Koppula from comment #7)
> TRY push:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=526d1326eb2201080bc0652e9ea62eef95efa937

The summary of the above TRY didn't show up bug specific commit. So pushed again,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d29054cf3a2a6c907f323a0a6079d68c2db5f7bc
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7d99b84c4820
Netmonitor header context menu should appear even by right clicking a blank area of the header. r=Honza
https://hg.mozilla.org/mozilla-central/rev/7d99b84c4820
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Assignee: nobody → abhinav.koppula
Reproduced the issue on v 59.0a1 20171116220410. 
Verified the fix using 59.0a1 20171211105838   on Windows 10 x64, MacOsx 10.5.5, Ubuntu 17.04x64
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.