BatchingClientTests failing after Swift 3.1 upgrade

RESOLVED FIXED

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sleroux, Assigned: sleroux)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios8.0+)

Details

(Whiteboard: [MobileCore])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The following tests are now failing on BB after switching over to Xcode 8.3

StorageClientTests
	testOverSizeRecords()

Sync15BatchClientTests
	testAddLargeRecordFails()	
	testFailToSerializeRecord()

Looks like Swift 3.1 fixed some error type coercion we were abusing in past versions of Swift.
(Assignee)

Comment 1

2 years ago
Created attachment 8854891 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2596
Attachment #8854891 - Flags: review?(fpatel)

Updated

2 years ago
Attachment #8854891 - Flags: review?(fpatel) → review+
(Assignee)

Comment 2

2 years ago
master 46e4624f94259d2dd8de54b83a9f88d7b3958541
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.