Closed Bug 1353746 Opened 7 years ago Closed 7 years ago

BatchingClientTests failing after Swift 3.1 upgrade

Categories

(Firefox for iOS :: Build & Test, enhancement, P1)

Product:
Firefox for iOS
Component:
Build & Test
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.19
Tracking Flags:
Tracking Status
fxios 8.0+ ---

People

(Reporter: sleroux, Assigned: sleroux)

Details

(Whiteboard: [MobileCore])

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2596
55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review 
The following tests are now failing on BB after switching over to Xcode 8.3

StorageClientTests
	testOverSizeRecords()

Sync15BatchClientTests
	testAddLargeRecordFails()	
	testFailToSerializeRecord()

Looks like Swift 3.1 fixed some error type coercion we were abusing in past versions of Swift.
Attachment #8854891 - Flags: review?(fpatel) → review+
master 46e4624f94259d2dd8de54b83a9f88d7b3958541
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: