Closed
Bug 1353755
Opened 7 years ago
Closed 7 years ago
remove nsCharTraits::assign
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
2.63 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
We don't need the tiny helper function for single-character assignment, and the multi-argument assign() method is the only thing that uses it, which is also itself unused. So remove them both.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8854886 -
Flags: review?(erahm)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8854886 [details] [diff] [review] remove nsCharTraits::assign Review of attachment 8854886 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8854886 -
Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/15a7986846aa remove nsCharTraits::assign; r=erahm
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/15a7986846aa
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/projects/cedar/rev/15a7986846aaa647dfd33c9a1709b0179ab36a31 Bug 1353755 - remove nsCharTraits::assign; r=erahm
You need to log in
before you can comment on or make changes to this bug.
Description
•