Ensure that TypedArray.prototype.fill does one coercion

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript: Standard Library
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: anba, Assigned: anba)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Comment 1

a year ago
Created attachment 8855252 [details] [diff] [review]
bug1353775.patch

https://github.com/tc39/test262/pull/927 added a new test to ensure ToNumber is only called once, so we only need tests for the detached array buffer case.

(The ecma_2017/**/shell.js changes only remove a blank line which was added by my editor.)
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8855252 - Flags: review?(evilpies)
(Assignee)

Comment 2

a year ago
And I've already switched steps 3-4 in the %TypedArray%.prototype.fill function per https://github.com/tc39/ecma262/pull/866.
Comment on attachment 8855252 [details] [diff] [review]
bug1353775.patch

Review of attachment 8855252 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, much better semantics.
Attachment #8855252 - Flags: review?(evilpies) → review+
(Assignee)

Comment 4

a year ago
Created attachment 8855760 [details] [diff] [review]
bug1353775.patch

Forgot to update js/src/tests/Makefile.in to add the new test directory, carrying r+ from evilpie.
Attachment #8855252 - Attachment is obsolete: true
Attachment #8855760 - Flags: review+

Comment 6

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f272e23f260f
Update TypedArray.prototype.fill to perform ToNumber(value) only once. r=evilpie
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f272e23f260f
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.