Closed
Bug 1353775
Opened 7 years ago
Closed 7 years ago
Ensure that TypedArray.prototype.fill does one coercion
Categories
(Core :: JavaScript: Standard Library, enhancement)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file, 1 obsolete file)
|
5.18 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•7 years ago
|
||
https://github.com/tc39/test262/pull/927 added a new test to ensure ToNumber is only called once, so we only need tests for the detached array buffer case. (The ecma_2017/**/shell.js changes only remove a blank line which was added by my editor.)
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8855252 -
Flags: review?(evilpies)
|
|
Assignee | |
Comment 2•7 years ago
|
||
And I've already switched steps 3-4 in the %TypedArray%.prototype.fill function per https://github.com/tc39/ecma262/pull/866.
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8855252 [details] [diff] [review] bug1353775.patch Review of attachment 8855252 [details] [diff] [review]: ----------------------------------------------------------------- Nice, much better semantics.
Attachment #8855252 -
Flags: review?(evilpies) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
Forgot to update js/src/tests/Makefile.in to add the new test directory, carrying r+ from evilpie.
Attachment #8855252 -
Attachment is obsolete: true
Attachment #8855760 -
Flags: review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=49781ea1c0a8f060b4e0ee79304bf64eafea159c
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f272e23f260f Update TypedArray.prototype.fill to perform ToNumber(value) only once. r=evilpie
Keywords: checkin-needed
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f272e23f260f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•