Fixups in commitindex and conduitdemo docker-compose to get bugzilla integration working

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: imadueme, Assigned: imadueme)

Tracking

Details

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8854980 [details]
conduitdemo: fixups to get bugzilla integration to work (bug 1353815).

https://reviewboard.mozilla.org/r/126898/#review129682

::: commitindex/commitindex/reviews/triggers.py:36
(Diff revision 3)
>  
> -        commit['attachment_id'] = bugzilla.create_attachment(
> +        attachments.append(bugzilla.create_attachment(
>              1, commit_data, api_key=api_key
> -        )
> +        ))
>  
> -    return commits
> +    return attachments

From 'invoke lint':

-        attachments.append(bugzilla.create_attachment(
-            1, commit_data, api_key=api_key
-        ))
+        attachments.append(
+            bugzilla.create_attachment(1, commit_data, api_key=api_key)
+        )

Comments:
1. Should there only be one attachment per commit id in Bugzilla? So why not just add the attachment_id as before?

commit['attachment_id'] = bugzilla.create_attachment(
    1, commit_data, api_key=api_key
)

2. The caller of trigger_review() will get a list of attachments back without any mapping to their related commit id which is why I thought it would be best to include it in the commits[] list of dictionaries returned.

::: conduitdemo/docker-vct-hg/hgrc:10
(Diff revision 3)
>  reviewboard = /root/version-control-tools/hgext/reviewboard/client.py
>  conduit = /root/version-control-tools/hgext/conduit-client/client.py
>  
>  [bugzilla]
> -username = test@example.com
> +username = conduit@mozilla.bugs
>  # Not a real api key

remove this comment as it is a real API key in the bmo container for the conduit user.
Attachment #8854980 - Flags: review?(dkl) → review-

Comment 5

2 years ago
mozreview-review
Comment on attachment 8854980 [details]
conduitdemo: fixups to get bugzilla integration to work (bug 1353815).

https://reviewboard.mozilla.org/r/126898/#review129918

Fix issues post-landing. r=dkl
Attachment #8854980 - Flags: review- → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8854980 [details]
conduitdemo: fixups to get bugzilla integration to work (bug 1353815).

https://reviewboard.mozilla.org/r/126898/#review129924

r+ for landing
Attachment #8854980 - Flags: review+

Comment 7

2 years ago
Pushed by mfogels@mozilla.com:
https://hg.mozilla.org/automation/conduit/rev/546f6907f713
conduitdemo: fixups to get bugzilla integration to work . r=dkl,mars
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.