1353859 - SeaMonkey Preferences are being emasculated

Status: RESOLVED INVALID

(SeaMonkey :: Preferences, enhancement)

Description

[Tony Mechelynck [:tonymec]]

A lot of frames in our nice Netscape-like Preferences dialog have become do-nothing areas recently. So I decided that too much is too much, took my DXR pickaxe and went digging into the code for the string "disable_button". Here is the query: https://dxr.mozilla.org/comm-central/search?q=disable_button&redirect=false

And here at bottom are the results, from a new addition to my user.js.
- People like me, who like being in control, may want to add these to user.js too;
- People like Mike Kaply and his paying customers, sysadmins who want to take control away from their users, may want to set them (or most of them) to true and lock them;
- If some or all of these buttons are wanted unhidden in SeaMonkey's Preferences dialog, the corresponding lines (but with pref instead of user_pref) might be added wherever it is that SeaMonkey's specific default preferences (as opposed to Firefox's or Thunderbird's) are set.

Caution: I copied _all_ the disable_button preferences. Some of them might be specific to Firefox or Thunderbird, but what the hell, what we don't use can't hurt us (and, with the opposite setting, might help mkaply and his customers).

Now here comes the code:

/* Enable all buttons.
 * We're placing these prefs out of order in order to group them together.
 */
user_pref("app.update.disable_button.showUpdateHistory", false);
user_pref("ldap_2.disable_button.add", false);
user_pref("mail.disable_button.delete_account", false);
user_pref("mail.disable_button.set_default_account", false);
user_pref("mail.server.default.disable_button.selectFolder");
user_pref("mail.server.default.disable_button_download", false);
	/* the above two are guesses:
	 * { prefstring:"disable_button.selectFolder", id:"selectNewsgroupsButton"},
	 * { prefstring:"disable_button.selectFolder", id:"selectImapFoldersButton"}
	 * in mailnews/base/prefs/content/am-offline.js
	 * and:
	 * gCurrentDirectory.dirPrefId + ".disable_button_download"
	 * in mailnews/addrbook/prefs/content/pref-directory-add.js */
user_pref("pref.advanced.cache.disable_button.clear_disk", false);
user_pref("pref.advanced.cookies.disable_button.view_cookies", false);
user_pref("pref.advanced.images.disable_button.view_image", false);
user_pref("pref.advanced.password.disable_button.view_stored_password", false);
user_pref("pref.advanced.popups.disable_button.preview_sound", false);
user_pref("pref.advanced.popups.disable_button.select_sound", false);
user_pref("pref.advanced.popups.disable_button.view_popups", false);
user_pref("pref.advanced.proxies.disable_button.advanced", false);
user_pref("pref.advanced.proxies.disable_button.reload", false);
user_pref("pref.browser.disable_button.default_browser", false);
user_pref("pref.browser.history.disable_button.clear_hist", false);
user_pref("pref.browser.history.disable_button.clear_urlbar", false);
user_pref("pref.browser.homepage.disable_button.bookmark_page", false);
user_pref("pref.browser.homepage.disable_button.current_group", false);
user_pref("pref.browser.homepage.disable_button.current_page", false);
user_pref("pref.browser.homepage.disable_button.default_page", false);
user_pref("pref.browser.homepage.disable_button.restore_default", false);
user_pref("pref.browser.homepage.disable_button.select_file", false);
user_pref("pref.browser.language.disable_button.add", false);
user_pref("pref.browser.language.disable_button.down", false);
user_pref("pref.browser.language.disable_button.up", false);
user_pref("pref.browser.language.disable_button.remove", false);
user_pref("pref.downloads.disable_button.edit_actions", false);
user_pref("pref.general.disable_button.default_browser", false);
user_pref("pref.general.disable_button.default_mail", false);
user_pref("pref.junk.disable_button.openJunkLog", false);
user_pref("pref.junk.disable_button.resetTrainingData", false);
user_pref("pref.ldap.disable_button.edit_directories", false);
user_pref("pref.privacy.disable_button.change_blocklist", false);
user_pref("pref.privacy.disable_button.cookie_exceptions", false);
user_pref("pref.privacy.disable_button.tracking_protection_exceptions", false);
user_pref("pref.privacy.disable_button.view_cookies", false);
user_pref("pref.privacy.disable_button.view_password_exceptions", false);
user_pref("pref.privacy.disable_button.view_passwords", false);
user_pref("pref.tags.disable_button.add", false);
user_pref("pref.tags.disable_button.delete", false);
user_pref("pref.tags.disable_button.lower", false);
user_pref("pref.tags.disable_button.raise", false);
user_pref("pref.tags.disable_button.restore", false);
user_pref("security.disable_button.changePassword", false);
user_pref("security.disable_button.openCertManager", false);
user_pref("security.disable_button.openDeviceManager", false);
user_pref("security.disable_button.resetPassword", false);
user_pref("services.sync.prefs.sync.pref.advanced.images.disable_button.view_image", false);
user_pref("services.sync.prefs.sync.pref.advanced.javascript.disable_button.advanced", false);
user_pref("services.sync.prefs.sync.pref.downloads.disable_button.edit_actions", false);
user_pref("services.sync.prefs.sync.pref.privacy.disable_button.cookie_exceptions", false);

Comment 1

[Tony Mechelynck [:tonymec]]

INVALID (Not a Mozilla bug).
My problem is with the EarlyBlue theme: in Modern the prefs dialog (and the checkbox on the are-you-sure dialog for "Help → Restart with Add-ons Disabled", which EarlyBlue also hides) are OK.

Comment 2

[Robert Kaiser]

(In reply to Tony Mechelynck [:tonymec]. (NEEDINFO me if you want my attention) from comment #1)
> INVALID (Not a Mozilla bug).
> My problem is with the EarlyBlue theme: in Modern the prefs dialog (and the
> checkbox on the are-you-sure dialog for "Help → Restart with Add-ons
> Disabled", which EarlyBlue also hides) are OK.

1) Which version of SeaMonkey?
2) Which version of EarlyBlue?
3) What is actually missing/wrong, can you give me a concrete example?

Comment 3

[Robert Kaiser]

FWIW, checkboxes being broken was a bug of EarlyBlue (toolkit removed the XBL binding I was pointing to) which I fixed in the development trunk of EarlyBlue, but not sure if that will land in any EarlyBlue release as I will only do releases if a matching SeaMonkey version is being released at all (and it looks like SM is unable to get releases done atm - I read the discussions, I know the problems with that and that ewong is doing great work trying to get us back on track in some form, but the result is still no releases).

Comment 4

[Tony Mechelynck [:tonymec]]

(In reply to Robert Kaiser from comment #2)
> (In reply to Tony Mechelynck [:tonymec]. (NEEDINFO me if you want my
> attention) from comment #1)
> > INVALID (Not a Mozilla bug).
> > My problem is with the EarlyBlue theme: in Modern the prefs dialog (and the
> > checkbox on the are-you-sure dialog for "Help → Restart with Add-ons
> > Disabled", which EarlyBlue also hides) are OK.
> 
> 1) Which version of SeaMonkey?
> 2) Which version of EarlyBlue?
> 3) What is actually missing/wrong, can you give me a concrete example?

Ah, sorry, I only noticed this today. While I was still using EarlyBlue, it was always the latest version I could find at https://git-public.kairo.at/themes/ in the latest linux64 trunk nightly of SeaMonkey, or on days without a nightly, some hourly "tinderbox-build" if there was any.

Since then I have switched to the MicroMonkey theme, which seems to work reasonably satisfactorily even though it hasn't been updated since 2015-06-04. I see there has been a big update for both EarlyBlue and LCARSTrek this morning (by my clock: 2017-11-07 UTC+2h); I might try it again to see if the bug is still present but probably not before next weekend.