135391 - win32 gmake build fails if drive is not mapped to /cygdrive/X

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Brian Ryner (not reading)]

cygwin allows you a fair amount of flexibility to configure mount points.  If
you change it so that your moztools directory isn't under /cygdrive/X, we fail
because of the sed substitution.

I believe there's a better fix that makes use of the "cygpath" program included
in cygwin. I'll attach a patch.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[hacker formerly known as [e-mail]]

Comment on attachment 77627 [details] [diff] [review]
patch

r=cls.	That'll work though I'm wondering how we want to handle this general
problem of cygwin mounts.  Will we have any problems if someone tries to build
on a drive that's not cygwin mounted?  Should we state that as a requirement?

Btw, I have a patch to automate the setting of --srcdir which uses cygpath -u. 
I don't know if cygpath will check to see if the drive is mounted or not for
the -u case.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 77627 [details] [diff] [review]
patch

a=[e-mail] for drivers

Comment 4

[cls]

Fixed.