1353979 - Permission panel jumps horizontally before it disappears when switching from one tab to another

Status: NEW

(Firefox :: Site Permissions, defect, P5)

Description

[684sigma]

Attachment: Permission panel jumps horizontally when switching tabs, by reporter.webm

I have a problem with Firefox Beta 53. It also happens in Nightly 55, doesn't happen in Beta 52, ESR 45.
When switching from one tab to another, permissions panels jump horizontally before they disappear. (All buttons in site identity block update in two steps. In first step all buttons from the second tab appear, in the second step permission button from the first tab disappears. Permission panel jumps during the first step).
Here's how to reproduce the bug:

1. Open 2 tabs with https://permission.site/ : in first tab permission panel should be opened, in second tab permission panel should not be opened.
2. Switch to the first tab. Switch to the second tab.

Result: Permission panel jumps to the right, then disappears
Expected: Permission panel shouldn't jump

Comment 1

[684sigma]

Just verified that it indeed started from Beta 53 and Nightly 55 (2017-04-03) is affected.

Comment 2

[Loic]

I think I see the issue, probably more or less visible following the perf of the machine.
Switching regularly between 2 same tabs with 1 permission panel open makes the permission panel and identity icon/favicon "blink".

STR:
1) Open https://permission.site/ click on "Location" and don't allow access when the permission panel opens
2) Open https://permission.site/ in a 2nd tab and click on "Location" (permission panel opens)
3) Switch fastly bewteen both tabs

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d4d3a7b6d57e06891f158ccb4bebf507a8d55d32&tochange=98cbc58cc6bc7bbdd6af853173b1c12b10ad47a1

Johann Hofmann — Bug 1206232 - Add temporary permission states to SitePermissions.jsm. r=jdm,Paolo

Comment 3

[Marcia Knous [:marcia]]

Too late for a fix for 53, as we are heading into the last week of the beta 53 cycle and no one is assigned.

Comment 4

[Johann Hofmann [:johannh]]

I don't think bug 1206232 caused this issue, it just added an indicator for temporarily blocked permissions that can be used to reproduce this.

In any case, I'd consider this P5 due to the complex STR.