|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
There aren't enough things using the woff and brotli code to need their headers under dist/include. OTOH, they have similarly (and generically) named headers that conflict with each other. Luckily, it's not apparently currently breaking anything, but that's a bad situation to be in. To be more specific, woff2_out.h includes port.h. When ots includes that header through woff_dec.h, it picks it up from dist/include, and picks port.h from there too... but port.h in dist/include comes from brotli... and woff has a *different* port.h in modules/woff2/src.
Comment on attachment 8855172 [details] Bug 1353990 - Stop exporting woff2 headers. https://reviewboard.mozilla.org/r/127052/#review130116
Comment on attachment 8855173 [details] Bug 1353990 - Stop exporting brotli headers. https://reviewboard.mozilla.org/r/127054/#review130118 This makes me wonder if we should have an allow list of exported headers. Obviously we can always allow mozilla/ files. But that's a topic for another day.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/0d8f901e6435 Stop exporting woff2 headers. r=gps https://hg.mozilla.org/integration/autoland/rev/5c6da13f6288 Stop exporting brotli headers. r=gps