Stop exporting the woff2 and brotli headers

RESOLVED FIXED in Firefox 55

Status

()

Core
Graphics: Text
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

8 months ago
There aren't enough things using the woff and brotli code to need their headers under dist/include. OTOH, they have similarly (and generically) named headers that conflict with each other. Luckily, it's not apparently currently breaking anything, but that's a bad situation to be in.

To be more specific, woff2_out.h includes port.h. When ots includes that header through woff_dec.h, it picks it up from dist/include, and picks port.h from there too... but port.h in dist/include comes from brotli... and woff has a *different* port.h in modules/woff2/src.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

8 months ago
mozreview-review
Comment on attachment 8855172 [details]
Bug 1353990 - Stop exporting woff2 headers.

https://reviewboard.mozilla.org/r/127052/#review130116
Attachment #8855172 - Flags: review?(gps) → review+

Comment 4

8 months ago
mozreview-review
Comment on attachment 8855173 [details]
Bug 1353990 - Stop exporting brotli headers.

https://reviewboard.mozilla.org/r/127054/#review130118

This makes me wonder if we should have an allow list of exported headers. Obviously we can always allow mozilla/ files. But that's a topic for another day.
Attachment #8855173 - Flags: review?(gps) → review+

Comment 5

8 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/0d8f901e6435
Stop exporting woff2 headers. r=gps
https://hg.mozilla.org/integration/autoland/rev/5c6da13f6288
Stop exporting brotli headers. r=gps

Comment 6

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0d8f901e6435
https://hg.mozilla.org/mozilla-central/rev/5c6da13f6288
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Comment 7

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0d8f901e6435
https://hg.mozilla.org/mozilla-central/rev/5c6da13f6288
You need to log in before you can comment on or make changes to this bug.