1354014 - The perf buttons shrinks even if there is enough space

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1350228

The Perf button displayed in the status bar and (containing an icon as well as labels) is shrinking, i.e. hiding the labels and only showing the icon - even if there is enough space.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: perf.png

STR:

1) Open DevTools 
2) Dock to the right side
3) Check out the Perf button in the Status bar (see also the attached screenshot)

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@ntim: should we just remove this CSS rule:
http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/assets/styles/netmonitor.css#1291

Honza

Comment 3

[Tim Nguyen :ntim]

(In reply to Jan Honza Odvarko [:Honza] from comment #2)
> @ntim: should we just remove this CSS rule:
> http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/
> assets/styles/netmonitor.css#1291
> 
> Honza

Yes, that sounds good.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1354014 - Fix Status bar layout;

Review commit: https://reviewboard.mozilla.org/r/127114/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127114/

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8855244 [details]
Bug 1354014 - Fix Status bar layout;

https://reviewboard.mozilla.org/r/127114/#review129896

It would be nice to have ellipsis text-overflow.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad720a1b50b1
Fix Status bar layout; r=ntim

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad720a1b50b1

Comment 8

[Ciprian Georgiu, Desktop QA]

I've managed to reproduce this issue on Nightly from 2017-04-05.

This is no longer reproducible with latest Nightly 55.0a1 (2017-04-10) under the following OSes:
- Windows 10 x64
- Mac OS X 10.11.6
- Ubuntu 16.04 x64 LTS