1354021 - click link in Stack Trace panel does not open trace code on debugger

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect)

Description

[[e-mail]]

Tested on Linux Nightly Desktop (fx55)

1. pen a website https://en.wikipedia.org/wiki/United_States and open devtools > netmonitor
2. Click on a request with (js) label on it, will show the `Stack Trace` panel
3. Click on right side links in `Stack Trace` panel

Expect:

Open the source on debugger panel

Actual:

Open a blank new browser tab

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can confirm this bug. A blank new browser tab is opened.

I can also see this exception:
[JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.loadURI]" {file: "chrome://global/content/viewSource-content.js" line: 354}]

Could this issue be related to bug 1350234?
Or was the problem already there before?

Honza

Comment 2

[[e-mail]]

I can link to debugger correctly last week (before moving to Stack Trace panel in bug 1350234), so it might related

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1354021 - Open source in the Debugger panel;

Review commit: https://reviewboard.mozilla.org/r/127118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127118/

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8855249 [details]
Bug 1354021 - Open source in the Debugger panel;

https://reviewboard.mozilla.org/r/127118/#review129898

Fixes the issue, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c47a7f943eab
Open source in the Debugger panel; r=ntim

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the reviews Tim!

Honza

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c47a7f943eab

Comment 8

[Md. Majedul islam]

I have reproduced this bug with nightly 55.0a1 (2017-04-06)  on Ubuntu 16.04(64 Bit).

The bug's fix is now verified on Latest nightly 55.0a1.

Build ID   : 20170518100156

User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[Bugday-20170517]