Closed Bug 1354085 Opened 4 years ago Closed 4 years ago

Tab is sometimes not rendered when moved from background to foreground

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

patch - Fix WebRenderLayerManager::NeedsWidgetInvalidation()
1.29 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review 
Sometimes, a Tab is not rendered when it is moved from background to foreground. It seems related to LayerObserverEpoch.
Assignee: nobody → sotaro.ikeda.g
Blocks: webrender
TabChild::RecvSetDocShellIsActive() seems not works as expected since the following code hit.

> if (mLayerObserverEpoch >= aLayerObserverEpoch) {

 https://dxr.mozilla.org/mozilla-central/source/dom/ipc/TabChild.cpp#2461
The following did not trigger repaint.

> root->SchedulePaint();
  https://dxr.mozilla.org/mozilla-central/source/dom/ipc/TabChild.cpp#2523

Then LayerObserverEpoch was not updated by WebRenderBridgeParent::ProcessWebRenderCommands()

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/wr/WebRenderBridgeParent.cpp#406
Attachment #8855292 - Flags: review?(matt.woodrow)
Attachment #8855292 - Flags: review?(matt.woodrow) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/75bf917f3696
Fix WebRenderLayerManager::NeedsWidgetInvalidation() r=mattwoodrow
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
status-firefox55: --- → fixed
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.