Closed Bug 1354119 Opened 4 years ago Closed 4 years ago

Add 'Find in Page...' and 'Help' buttons to static hamburger menu

Categories

(Firefox :: Toolbars and Customization, enhancement, P1)

Product:
Firefox
Component:
Toolbars and Customization
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Iteration:
55.6 - May 29
Tracking Flags:
Tracking Status
firefox55 --- verified

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [photon-structure])

Attachments

(1 file)

Bug 1354119 - Add a Find in Page and Help subview button and panel to the photon app menu.
59 bytes, text/x-review-board-request
Gijs
: review+
Details 
These new buttons are copied from the main 'Edit' and 'Help' menus. The icon will be smaller; the size to be the same as all other menu item icons. In order of appearance:

* The 'Find in Page...' button is a new widget that will show the Find Toolbar. There's no icon shown.
* The 'Help' button is a new widget that will show the 'Firefox Help' website. There's a new question mark icon shown.

Commands are the same as the menu items in the 'Edit' and 'Help' menus, respectively.

Please take a (possible future) hotkey assignment into account. (no pun intended.)
Blocks: 1354120
Blocks: 1354127
Blocks: 1354128
No longer blocks: 1354127, 1354128, 1354120
No longer depends on: 1354116
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Iteration: --- → 55.5 - May 15
Priority: P2 → P1
Comment on attachment 8866883 [details]
Bug 1354119 - Add a Find in Page and Help subview button and panel to the photon app menu.

https://reviewboard.mozilla.org/r/138484/#review142086

I am a fan of how easy this stuff is turning out to be with your earlier panelmultiview changes. Great work!

::: browser/themes/shared/menu-icons/find.svg:1
(Diff revision 1)
> +<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">

Nit: here and for 'help.svg', no viewBox attribute and a license header, please.
Attachment #8866883 - Flags: review?(gijskruitbosch+bugs) → review+
Iteration: 55.5 - May 15 → 55.6 - May 29
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8c5ff8e2c50
Add a Find in Page and Help subview button and panel to the photon app menu. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/e8c5ff8e2c50
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Verified in Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.