Closed Bug 1354119 Opened 5 years ago Closed 5 years ago
Add 'Find in Page
...' and 'Help' buttons to static hamburger menu
59 bytes, text/x-review-board-request
These new buttons are copied from the main 'Edit' and 'Help' menus. The icon will be smaller; the size to be the same as all other menu item icons. In order of appearance: * The 'Find in Page...' button is a new widget that will show the Find Toolbar. There's no icon shown. * The 'Help' button is a new widget that will show the 'Firefox Help' website. There's a new question mark icon shown. Commands are the same as the menu items in the 'Edit' and 'Help' menus, respectively. Please take a (possible future) hotkey assignment into account. (no pun intended.)
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Comment on attachment 8866883 [details] Bug 1354119 - Add a Find in Page and Help subview button and panel to the photon app menu. https://reviewboard.mozilla.org/r/138484/#review142086 I am a fan of how easy this stuff is turning out to be with your earlier panelmultiview changes. Great work! ::: browser/themes/shared/menu-icons/find.svg:1 (Diff revision 1) > +<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16"> Nit: here and for 'help.svg', no viewBox attribute and a license header, please.
Attachment #8866883 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/e8c5ff8e2c50 Add a Find in Page and Help subview button and panel to the photon app menu. r=Gijs
Verified in Windows, Mac, and Ubuntu.
You need to log in before you can comment on or make changes to this bug.