If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

webRequest.onSendHeaders doesn't see header modifications from onBeforeSendHeaders

RESOLVED WORKSFORME

Status

()

Toolkit
WebExtensions: Request Handling
RESOLVED WORKSFORME
6 months ago
6 months ago

People

(Reporter: zombie, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 months ago
Writing a test for bug 1323036, read this:

> If you want to see the headers that are actually sent, without the risk that 
> another add-on will subsequently alter them, use onSendHeaders, although you 
> can't modify headers on this event.

from https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webRequest/onBeforeSendHeaders

This doesn't seem to be true.
I'm pretty sure we have tests for this.
(Reporter)

Comment 2

6 months ago
You are right, of course.

I likely added a second onBeforeSendHeaders listener instead, exactly as I've done just now, while trying to reproduce this.

(It's a perfect mistake -- it behaved exactly as expected from onSendHeaders, except for the observed "bug" :/)
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.