Closed Bug 1354205 Opened 2 years ago Closed 2 years ago

Remove FUEL

Categories

(Toolkit :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: mossop, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is only used by old-style add-ons and so once they have gone it can be removed.
Is this already done by bug 1090880?
Di you mean extIApplication here?
(In reply to :aceman from comment #1)
> Is this already done by bug 1090880?
> Di you mean extIApplication here?

That and https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/test_fuel.js
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Wait, I thought extApplication.js was not supposed to be removed. Or was that just meant that it will be removed much later than FUEL itself, so e.g. now?
If so, we use it in TB and need to remove STEEL that uses extApplication.js. We have the patch ready in bug 1278067.
And of course Seamonkey with SMILE.
Blocks: 1278067
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Trunk
(In reply to :aceman from comment #5)
> Wait, I thought extApplication.js was not supposed to be removed.

Why not?

> If so, we use it in TB and need to remove STEEL that uses extApplication.js.
> We have the patch ready in bug 1278067.
> And of course Seamonkey with SMILE.

Right, it seems that you should just get rid of those too. Or if there's some reason against doing that, pull extApplication.js into Thunderbird/Seamonkey.
It may be that it just wasn't yet sure what the plan is 2 years ago (bug 1090880 comment 3).
We do not use STEEL anymore in TB core, we've done preparations this time. Just some addons still use it. Then again many addons still use the long removed FUEL :)
Comment on attachment 8893391 [details]
Bug 1354205 - Remove FUEL remnants.

https://reviewboard.mozilla.org/r/164510/#review169976

Looks good.
Attachment #8893391 - Flags: review?(dtownsend) → review+
(In reply to :aceman from comment #7)
> It may be that it just wasn't yet sure what the plan is 2 years ago (bug
> 1090880 comment 3).
> We do not use STEEL anymore in TB core, we've done preparations this time.
> Just some addons still use it. Then again many addons still use the long
> removed FUEL :)

Do you want us to defer landing this for a day or two to import this file to comm-central?
Flags: needinfo?(acelists)
Yes, please. We are coming to an agreement in bug 1278067.
Please land this on Monday if possible. Thanks.
Flags: needinfo?(acelists)
https://hg.mozilla.org/mozilla-central/rev/1d7af093298b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/838073194362
Port bug 1354205 to TB/IB/SM: remove exthelper.xpt from package manifests. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.