1354206 - Crash in iframes

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Diego Marcos [:dmarcos]]

Steps to reproduce:

1. Open Nightly and enable webvr / openvr.
2. Connect HTC Vive to the machine
3. Visit aframe.io
4. Click on the different examples on the left side menu (it's not necessary to enter VR)

Nightly becomes slow and eventually crashes when clicking through the examples.

Each example lives in its own page with an iframe that renders the VR scene. AFrame calls getVRDevices at load time.

My guess is that some VR related resource is allocated when getVRDevices that it's not properly released in the context of an iframe.

If the HTC Vive is not connected to the machine everything works as expected.

I verified this problem in two different machines (laptop and desktop) with GTX 1080 GPUs.

Comment 1

[Diego Marcos [:dmarcos]]

The steps above also reproduce with Oculus

Comment 2

[:kip (Kearwood Gilbert)]

Attachment: Bug 1354206 - Prevent VRDisplay.requestAnimationFrame from succeeding after shutdown

Review commit: https://reviewboard.mozilla.org/r/129640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129640/

Comment 3

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8857706 [details]
Bug 1354206 - Prevent VRDisplay.requestAnimationFrame from succeeding after shutdown

https://reviewboard.mozilla.org/r/129640/#review132362

LGTM, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26170413bbd0
Prevent VRDisplay.requestAnimationFrame from succeeding after shutdown r=daoshengmu

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/26170413bbd0