Closed Bug 1354206 Opened 4 years ago Closed 4 years ago

Crash in iframes

Categories

(Core :: WebVR, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: dmarcos, Assigned: kip)

Details

Attachments

(1 file)

Steps to reproduce:

1. Open Nightly and enable webvr / openvr.
2. Connect HTC Vive to the machine
3. Visit aframe.io
4. Click on the different examples on the left side menu (it's not necessary to enter VR)

Nightly becomes slow and eventually crashes when clicking through the examples.

Each example lives in its own page with an iframe that renders the VR scene. AFrame calls getVRDevices at load time.

My guess is that some VR related resource is allocated when getVRDevices that it's not properly released in the context of an iframe.

If the HTC Vive is not connected to the machine everything works as expected.

I verified this problem in two different machines (laptop and desktop) with GTX 1080 GPUs.
The steps above also reproduce with Oculus
Assignee: nobody → kgilbert
Attachment #8857706 - Flags: review?(dmu)
Comment on attachment 8857706 [details]
Bug 1354206 - Prevent VRDisplay.requestAnimationFrame from succeeding after shutdown

https://reviewboard.mozilla.org/r/129640/#review132362

LGTM, thanks!
Attachment #8857706 - Flags: review?(dmu) → review+
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26170413bbd0
Prevent VRDisplay.requestAnimationFrame from succeeding after shutdown r=daoshengmu
https://hg.mozilla.org/mozilla-central/rev/26170413bbd0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.