Closed
Bug 1354208
Opened 7 years ago
Closed 7 years ago
Add AccessibleHandler.dll to the installer
Categories
(Core :: Disability Access APIs, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
Details
Attachments
(1 file)
5.28 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
This DLL also requires COM (de)registration.
Assignee | ||
Comment 1•7 years ago
|
||
This patch adds AccessibleHandler.dll to the installer. This dll also requires COM registration. This DLL needs to use different CLSIDs depending on release channel, because it is tightly coupled to the version of Gecko that it is installed with. Bad things are possible if, for example, an AccessibleHandler.dll from Nightly were to be loaded and trying to interact with a release Firefox. The deregistration code must take this into account when checking whether it is safe to proceed. We do this via the AccessibleHandlerCLSID macro, which is defined differently depending on channel. Note that the registry value that we check is intentionally "InprocHandler32" (as opposed to the usual "InprocServer32").
Attachment #8855403 -
Flags: review?(robert.strong.bugs)
Comment 2•7 years ago
|
||
Comment on attachment 8855403 [details] [diff] [review] Add AccessibleHandler.dll to the installer Punting to mhowell who owns the installers.
Attachment #8855403 -
Flags: review?(robert.strong.bugs) → review?(mhowell)
Updated•7 years ago
|
Attachment #8855403 -
Flags: review?(mhowell) → review+
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3b4e04987c74a7e68b045c867f94c6f9bc1a5a6 Bug 1354208: Add AccessibleHandler.dll to installer; r=mhowell
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e3b4e04987c7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•