Closed Bug 1354208 Opened 7 years ago Closed 7 years ago

Add AccessibleHandler.dll to the installer

Categories

(Core :: Disability Access APIs, enhancement)

Unspecified
Windows
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

Attachments

(1 file)

This DLL also requires COM (de)registration.
This patch adds AccessibleHandler.dll to the installer. This dll also requires COM registration.

This DLL needs to use different CLSIDs depending on release channel, because it is tightly coupled to the version of Gecko that it is installed with. Bad things are possible if, for example, an AccessibleHandler.dll from Nightly were to be loaded and trying to interact with a release Firefox.

The deregistration code must take this into account when checking whether it is safe to proceed. We do this via the AccessibleHandlerCLSID macro, which is defined differently depending on channel.

Note that the registry value that we check is intentionally "InprocHandler32" (as opposed to the usual "InprocServer32").
Attachment #8855403 - Flags: review?(robert.strong.bugs)
Comment on attachment 8855403 [details] [diff] [review]
Add AccessibleHandler.dll to the installer

Punting to mhowell who owns the installers.
Attachment #8855403 - Flags: review?(robert.strong.bugs) → review?(mhowell)
Attachment #8855403 - Flags: review?(mhowell) → review+
https://hg.mozilla.org/mozilla-central/rev/e3b4e04987c7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: