Closed Bug 1354310 Opened 2 years ago Closed 2 years ago

Intermittent test_navigation.py TestNavigate.test_type_to_remote_tab | TimeoutException: Timed out after 5.0 seconds with message: 'http://127.0.0.1:49326/test.html' hasn't been loaded

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox-esr52 wontfix, firefox53 fixed, firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr52 --- wontfix
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: whimboo)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

This is a debug build and having a timeout of 5s for a page to be loaded seems wrong. Instead it should use `self.marionette.timeout.page_load`.

>        Wait(self.marionette).until(
>            lambda mn: mn.get_url() == self.test_page_remote,
>            message="'{}' hasn't been loaded".format(self.test_page_remote))

The same applies to the test `test_type_to_non_remote_tab`, and maybe others.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Comment on attachment 8855673 [details]
Bug 1354310 - Ensure to use page load timeout for Wait().until() in unit tests.

https://reviewboard.mozilla.org/r/127538/#review130352
Attachment #8855673 - Flags: review?(ato) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef76a3b0eb7d
Ensure to use page load timeout for Wait().until() in unit tests. r=ato
https://hg.mozilla.org/mozilla-central/rev/ef76a3b0eb7d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Please uplift this test-only patch to aurora and beta. Thank you.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-aurora/rev/0d8df2fe95cc
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-beta/rev/0fe6857edaff
Whiteboard: [checkin-needed-beta]
This'll need rebasing if you want to uplift to esr52.
Flags: needinfo?(hskupin)
If it would be a (near) perma-fail a backport patch would make sense. But as of now it doesn't warrant the work. So I will mark esr52 as wontfix. We can re-evaluate if it becomes a problem in the future.
Flags: needinfo?(hskupin)
You need to log in before you can comment on or make changes to this bug.