Support changing application branding of installed shortcuts during updates

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Installer
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: mhowell, Assigned: mhowell)

Tracking

Trunk
Firefox 55
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
When migrating users of one channel over to another channel via updates, we do not rename any existing shortcuts. So an installation that's been updated from Developer Edition to beta would still have shortcuts that say Developer Edition. We should fix this during the PostUpdate procedure for any shortcuts that we've installed.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

6 months ago
mozreview-review
Comment on attachment 8856556 [details]
Bug 1354321 - Rename installer-created shortcuts on update if the branding name has changed.

https://reviewboard.mozilla.org/r/128520/#review132180
Attachment #8856556 - Flags: review?(agashlin) → review+

Comment 4

6 months ago
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7799e2285c40
Rename installer-created shortcuts on update if the branding name has changed. r=agashlin

Comment 5

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7799e2285c40
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Hi :mhowell, 
According to comment #9, do you want to uplift this to Beta54, too?
Flags: needinfo?(mhowell)
(Assignee)

Comment 7

6 months ago
My understanding is that the plan is now to do separate builds off of beta using the dev edition branding. In that case, there's no uplift needed here.
Flags: needinfo?(mhowell)
(Assignee)

Comment 8

6 months ago
Or on bug 1357161 for that matter.
You need to log in before you can comment on or make changes to this bug.