1354332 - When enabling compact mode, the rightmost tab is hidden on the right and the tabstrip scroll buttons aren't updated (due to the changes in spacing in the tab/titlebar)

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Clément Lefèvre]

Attachment: Tabs with compact theme just after switch

When switching from standard theme to compact ones in nightly on Mac OS X, the rightmost tab is mostly hidden on the rightand the arrow besides it doesn't have the look showing you can slide tabs. Shadow isn't here either.

See joined screenshot: pretty much nothing more than the favicon is visible.

Comment 1

[Clément Lefèvre]

Might be related to bug https://bugzilla.mozilla.org/show_bug.cgi?id=1354225

Comment 2

[Dão Gottwald [:dao]]

Will be fixed by bug 1349555 and bug 1350210.

Comment 3

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #2)
> Will be fixed by bug 1349555 and bug 1350210.

Both of these are fixed, but at least on 57 on Windows, I now just see this issue when switching densities. Can we reuse this bug to address that, or is there another bug on file already? (I can't find one with bugzilla searching, though I could have sworn I saw something semi-recently...)

Comment 4

[:Gijs (he/him)]

Eh, didn't mean to close this, oops.

Comment 5

[Clément Lefèvre]

Attachment: When switching from compact to normal density

How do you still reproduce it Gijs?
For my part I can't anymore as you can't switch between compact and normal in about:addons anymore.

However I noticed another bug now by switching densities in the "Customize…" mode: when switching from compact to normal density, right border of the customize tab disappear. See the joined screenshot for that.

That's the same kind of issue that was visible in bug 1390025.

Comment 6

[:Gijs (he/him)]

(In reply to Clément Lefèvre from comment #5)
> However I noticed another bug now by switching densities in the "Customize…"
> mode: when switching from compact to normal density, right border of the
> customize tab disappear. See the joined screenshot for that.

Yes, this is effectively a similar bug, I believe. I see a worse effect when switching to/from 'touch' density (not available on macOS). The cause is still the same: changes in the sizing of items in/around the tabstrip which cause the tabstrip to scroll in one direction or another without the corresponding events firing.

Comment 7

[Dão Gottwald [:dao]]

Attachment: Bug 1354332 - Update the tab bar layout when the UI density changes.

Review commit: https://reviewboard.mozilla.org/r/199746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199746/

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 8928492 [details]
Bug 1354332 - Update the tab bar layout when the UI density changes.

https://reviewboard.mozilla.org/r/199746/#review205400

Seems good, thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/034443b19f2b
Update the tab bar layout when the UI density changes. r=johannh

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/034443b19f2b

Comment 11

[Clément Lefèvre]

Was the fix supposed to be present in 20171116220410?
If yes, then I'm still able to reproduce the issue when switching from compact to normal density.
Otherwise I'll wait for the next build.

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 8928492 [details]
Bug 1354332 - Update the tab bar layout when the UI density changes.

Approval Request Comment
[Feature/Bug causing the regression]: Firefox 57 compact mode
[User impact if declined]: pinned tabs are misaligned when enabling compact mode
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: pretty straightforward fix
[String changes made/needed]: /

Comment 13

[Gerry Chang [:gchang]]

Hi Clément,
Can you help check if this was fixed in the latest nightly again?

Comment 14

[Clément Lefèvre]

(In reply to Gerry Chang [:gchang] from comment #13)
> Hi Clément,
> Can you help check if this was fixed in the latest nightly again?

Yes it is now fixed.

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8928492 [details]
Bug 1354332 - Update the tab bar layout when the UI density changes.

Fix a misaligned pinned tabs issue when enabling compact mode and was verified. Beta58+.

Comment 16

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6302eed651db